refactor: Remove unused BlockAssembler::pblock member var #19283

1. 
   MarcoFalke commented at 12:14 pm on June 15, 2020: member

   It seems odd to have a confusing and fragile “convenience pointer” member variable to be able to write pblock->vtx instead of pblocktemplate->block.vtx in a single place.
2. refactor: Remove unused BlockAssembler::pblock member var fa6d5ab674
3. fanquake added the label Mining on Jun 15, 2020
4. fanquake added the label Refactoring on Jun 15, 2020
5. 
   DrahtBot commented at 7:41 pm on June 15, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19273 (Remove checks for nullptr from BlockAssembler::CreateNewBlock by cculianu)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   promag commented at 0:40 am on June 16, 2020: member

   Code review ACK fa6d5ab67444013f9db696cca2257c871e002594.
7. MarcoFalke merged this on Jul 9, 2020
8. MarcoFalke closed this on Jul 9, 2020

   ---

9. MarcoFalke deleted the branch on Jul 10, 2020
10. sidhujag referenced this in commit 3ec2d80ac3 on Jul 10, 2020
11. Fabcien referenced this in commit 0fb5b7364a on May 31, 2021
12. PastaPastaPasta referenced this in commit 17b7845853 on Jun 27, 2021
13. PastaPastaPasta referenced this in commit ad49c46efe on Jun 28, 2021
14. PastaPastaPasta referenced this in commit bd5c61ac1e on Jun 29, 2021
15. PastaPastaPasta referenced this in commit 80bd9a0b7a on Jul 1, 2021
16. PastaPastaPasta referenced this in commit f9e37b2ef5 on Jul 1, 2021
17. PastaPastaPasta referenced this in commit 0f016a1279 on Jul 15, 2021
18. PastaPastaPasta referenced this in commit d4d94dfb15 on Jul 16, 2021
19. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot promag

Labels
Refactoring Mining