It seems odd to have a confusing and fragile "convenience pointer" member variable to be able to write pblock->vtx instead of pblocktemplate->block.vtx in a single place.
refactor: Remove unused BlockAssembler::pblock member var #19283
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2006-minerPblock changing 2 files +2 −4-
MarcoFalke commented at 12:14 PM on June 15, 2020: member
-
refactor: Remove unused BlockAssembler::pblock member var fa6d5ab674
- fanquake added the label Mining on Jun 15, 2020
- fanquake added the label Refactoring on Jun 15, 2020
-
DrahtBot commented at 7:41 PM on June 15, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #19273 (Remove checks for nullptr from BlockAssembler::CreateNewBlock by cculianu)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
promag commented at 12:40 AM on June 16, 2020: member
Code review ACK fa6d5ab67444013f9db696cca2257c871e002594.
- MarcoFalke merged this on Jul 9, 2020
- MarcoFalke closed this on Jul 9, 2020
- MarcoFalke deleted the branch on Jul 10, 2020
- sidhujag referenced this in commit 3ec2d80ac3 on Jul 10, 2020
- Fabcien referenced this in commit 0fb5b7364a on May 31, 2021
- PastaPastaPasta referenced this in commit 17b7845853 on Jun 27, 2021
- PastaPastaPasta referenced this in commit ad49c46efe on Jun 28, 2021
- PastaPastaPasta referenced this in commit bd5c61ac1e on Jun 29, 2021
- PastaPastaPasta referenced this in commit 80bd9a0b7a on Jul 1, 2021
- PastaPastaPasta referenced this in commit f9e37b2ef5 on Jul 1, 2021
- PastaPastaPasta referenced this in commit 0f016a1279 on Jul 15, 2021
- PastaPastaPasta referenced this in commit d4d94dfb15 on Jul 16, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels