Non-GPL Icons, v2 #1931

laanwj commented at 11:06 AM on October 14, 2012: member

This replaces the spinner and connection icon with freer licensed ones.

I've slightly improved on #811:

Inactive bars in the connection icon are now visible. This better matches the current icon and prevents a nondescript "dot" in the status bar for 1 connection.
Remove commit xanatos@de6a850c84934ae5a1aff24e213c9abe7c2b9979 which was erroneously included

Changed the spinner to a non-GPL one, added instructions on how to regenerate it, changed the assets attribution, removed old spinner + old spinner's sources. b96238a9c9

Changed connect?_16.png to non-GPL one and changed the assets attribution. cddda5d9f0

xanatos commented at 11:21 AM on October 14, 2012: none

I had tested with the "inactive" bars but I wasn't sure what was better. Thanks for the removing of the commit.

Diapolo commented at 11:56 AM on October 14, 2012: none

ACK, just wondering if the icon looks a little sharper, when you supply a higher resolution and let Bitcoin-Qt resize it?

laanwj commented at 2:52 PM on October 14, 2012: member

@Diapolo Depends on what rescaling algorithm @xanatos used, but usually manually controlling the scaling result gives a better result than qt does "realtime". Anyway, I don't think it gets any sharper than this.

laanwj referenced this in commit 199d88cf90 on Oct 14, 2012

laanwj merged this on Oct 14, 2012

laanwj closed this on Oct 14, 2012

xanatos commented at 3:05 PM on October 14, 2012: none

If you want I have the 32x32 source. It is multilayer. It is in Paint.NET format.

in doc/assets-attribution.txt:None in cddda5d9f0

  20 | -License: GNU/GPL
  21 | -Site: http://findicons.com/icon/93743/blocks_gnome_netstatus_0
  22 | +Icon: src/qt/res/icons/connect*.png (edited, originally Wireless Signal.png)
  23 | +Icon Pack: The Clean Desk
  24 | +Designer:  Alfred Pereira
  25 | +License: freeware

luke-jr commented at 4:27 PM on October 14, 2012:

"freeware" generally means no rights except redistribution, which is less free than GPL...

in doc/assets-attribution.txt:None in cddda5d9f0

  48 | +Movie: src/qt/res/movies/update_spinner.mng
  49 | +Site: http://preloaders.net/en/circular
  50 | +License: You are encouraged and legally entitled to copy and modify any animated GIF and APNG images, generated by http://preloaders.net web-site.
  51 | +All animated GIF and APNG images are completely free to use in all projects (web and desktop applications, freeware and commercial projects), WITH THE EXCEPTION of any other animated images generator applications
  52 | +You are encouraged, but NOT obligated to place any reference to http://preloaders.net web-site to use it's content in any projects and applications.
  53 |

luke-jr commented at 4:27 PM on October 14, 2012:

This is not free.

luke-jr commented at 4:28 PM on October 14, 2012: member

Why was this merged, considering it makes Bitcoin-Qt non-free? At least GPL is free.

laanwj referenced this in commit 485d667748 on Oct 14, 2012

laanwj commented at 7:00 PM on October 14, 2012: member

Sorry, this has been reverted. We can only accept public domain and MIT (BSD/expat/...) licensed icons from now on.

Diapolo commented at 7:22 PM on October 14, 2012: none

I think it's rather good that we have some "eagle eye"-dev for such special thinks who watches and warns. What sometimes feels like nit-picking is wanting only the best for the client. So I would say @luke-jr is the guardian of licenses :-D.

laanwj commented at 5:32 AM on October 15, 2012: member

On the other hand I wasted my sunday morning on these icons. And @xanatos probably more time, so I wouldn't exactly call this a win.

And if that wasn't enough, I spent part of the evening on IRC trying to dispell Luke-Jr's bullshit that I'm some kind of dictator threatening to make Bitcoin non-free. I'm really pissed at the moment.

xanatos commented at 8:17 AM on October 15, 2012: none

I have to tell the truth, the position of Like-Jr feels a little Stallmanian, but in the end, this isn't a problem of mine. My part of work was done. Now someone else can redraw the icons. Can someone reopen my Issue and/or open a similar issue? The problem that those icons make the bitcoin-qt GPL still stand (and I think that at least as a stopgag the icons were ok, because it's better to restrict a little the freedom of reusing bitcoin-qt as an "animated images generator applications" than going against the rights of the persons that drawed those GPL icons, because while using the GPL icons in bitcoin-qt you are infringing a right of a third party, if you restrict the use of bitcoin-qt and you are the author/maintainer, that is your right)

luke-jr commented at 11:17 AM on October 15, 2012: member

@xanatos Bitcoin-Qt is fully in compliance with the terms imposed by the GPL'd icons.

xanatos commented at 11:52 AM on October 15, 2012: none

@luke-jr I hate hate hate myself. I just lost 30 minutes of my life, just to write this.

NO NO NO Just to be sure I have just installed the bitcoin-0.7.0-win32-setup.exe from SourceForge. Now.... There isn't any GPL.txt file (or similar file with the license) (this makes bitcoin incompatible with both GPL and LGPL), there isn't any LGPL.txt file (or similar file with the license) (this makes bitcoin incompatible with LGPL). And point 2b of the GPL license: b) You must cause any work that you distribute or publish, that in whole or in part contains or is derived from the Program or any part thereof, _to be licensed_ as a whole at no charge to all third parties _under the terms of this License_. The subject is YOU. I don't think it is enough that the software is relicenseable because it's MIT licensed. I think YOU (plural, not you luke-jr) would at least need to dual license it explicitly under MIT and GPL. And last, in the COPYING.txt file, the program is explicitly licensed under the MIT license. Now, morally you are perhaps fine with GPL because you are distributing the source code (it's even included in the installer, but note that it isn't complete... For example the bitcoin-qt.pro file is missing, so that you can't build the QT project. Point 3 of the GPL license: "plus the scripts used to control compilation and installation of the executable" so this copy of the source isn't enough. But you can download the source from this site, right? A shame that in all the installed files there isn't a link to this site or an email address of a programmer. The only link is to https://en.bitcoin.it/wiki/Main_Page)

luke-jr commented at 12:03 PM on October 15, 2012: member

@xanatos I suppose technically speaking we need to include a copy of the licenses, but that is hardly a big deal. Since the MIT license allows anyone to relicense the work under more restrictive terms, the rest of the code can be licensed by anyone under the terms of the GPL in addition to the MIT license. If the bitcoin-qt.pro file is missing from the installed source code, I think that is a bug. The (L)GPL licenses further also consider publishing the source code - even if on a different server - with equivalent accessibility, to be identical to including it verbatim with the binary object: therefore we do not strictly require a link included (though it would be a good idea).

laanwj deleted the branch on Apr 9, 2014

KolbyML referenced this in commit 65ca5e0255 on Dec 5, 2020

DrahtBot locked this on Sep 8, 2021