fix some thread related log messages #1932

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:thread_printf changing 2 files +6 −1

Diapolo commented at 11:52 AM on October 14, 2012: none
- "ThreadIRCSeed started" was not displayed, even if the thread ran (although only for a short time as the "do we want this thread?"-checks happen IN ThreadIRCSeed2())
- the patch ensures we always get that message
- add a "ThreadIRCSeed trying to connect..." message
- add missing "ThreadDumpAddress started" message
BitcoinPullTester commented at 10:00 AM on October 19, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ba43db93dd08141176ca50aff361bbecea5b17b8 for binaries and test log.

fix some thread related log messages

- "ThreadIRCSeed started" was not displayed, even if the thread ran
  (although only for a short time as the "do we want this thread?"-checks
  happen IN ThreadIRCSeed2())
- the patch ensures we always get that message
- add a "ThreadIRCSeed trying to connect..." message
- add missing "ThreadDumpAddress started" message

847593228d

in src/irc.cpp:None in ba43db93dd outdated
```
 219 | @@ -218,7 +220,6 @@ void ThreadIRCSeed2(void* parg)
 220 |      if (!GetBoolArg("-irc", false))
 221 |          return;
 222 |  
 223 | -    printf("ThreadIRCSeed started\n");
```
laanwj commented at 11:28 AM on October 25, 2012:

I think this old position was more useful; after all, we'd like to know when the IRCSeed thread starts to do actual work (connecting to IRC), not so much the pre-flight checks.

Diapolo commented at 11:31 AM on October 25, 2012:

Well IMO it doesn't make sense to see an "ThreadIRCSeed exited" message in the log, when there was no "ThreadIRCSeed started" message, because of the pre-checks. I think that message should tell us "hey the thread IS now running!", nothing more. And therefore the new code positioning.

laanwj commented at 11:38 AM on October 25, 2012:

Yes that's weird. It'd make sense to move the printf to ThreadIRCSeed, the same function that prints "XXX exited".

And replace the message at this line with something else "ThreadIRCSeed connecting" instead of removing it.

Diapolo commented at 2:13 PM on October 25, 2012:

Updated!
BitcoinPullTester commented at 12:14 AM on October 31, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/847593228de8634bf6ef5933a474c7e63be59146 for binaries and test log.
laanwj referenced this in commit 578fc80003 on Oct 31, 2012
laanwj merged this on Oct 31, 2012
laanwj closed this on Oct 31, 2012
laudney referenced this in commit 1fe581fe10 on Mar 19, 2014
KolbyML referenced this in commit f092c28c76 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

BitcoinPullTester

laanwj