test: Fix intermittent test failure in feature_backwards_compatibility #19332

1. 
   MarcoFalke commented at 10:46 pm on June 19, 2020: member

   All nodes are connected linearly, so tx relay not only makes the test slow, but also intermittently failing (timing out). Fixes #18969.

   Fix both issues by enabling immediate tx relay.

2. MarcoFalke force-pushed on Jun 19, 2020
3. DrahtBot added the label Tests on Jun 19, 2020
4. 
   DrahtBot commented at 3:36 am on June 20, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19013 (test: add v0.20.1, v0.21.0 and v22.0 to backwards compatibility test by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   Sjors commented at 9:42 am on June 23, 2020: member

   Linear transaction relay is a feature. We want to make sure new nodes don’t ban old nodes and vice versa. Especially if we add some interesting transactions to this test.

   I would prefer if there was a more fine grained permission than PF_NOBAN to avoid delay: bool fSendTrickle = pto->HasPermission(PF_NOBAN);. If that takes too long, then a // TODO in the test is fine too.

6. DrahtBot added the label Needs rebase on Sep 3, 2020
7. test: Fix intermittent test failure in feature_backwards_compatibility fa685965a1
8. MarcoFalke force-pushed on Dec 15, 2021
9. DrahtBot removed the label Needs rebase on Dec 15, 2021
10. 
    MarcoFalke commented at 3:22 pm on December 15, 2021: member

    Rebased and removed mention of travis in the pull request description
11. 
    Sjors commented at 5:51 am on December 16, 2021: member

    Oh I think I misread the description: I though you wanted to get rid of linear relay, but you’re just getting rid of the random delays. That’s fine.

    I cherry-picked this into #19013, which would save me from having to rebase this across lots of commits.

12. theStack approved
13. 
    theStack commented at 10:19 pm on December 19, 2021: member

    Tested ACK fa685965a1cb119d95a80e6c6100fca63861ed85

    As expected and mentioned in the PR description, this fix also speeds up the test tremendously. On my Debian machine:

    master:

    0$ time ./test/functional/feature_backwards_compatibility.py
    1real    1m18.605s
    2user    0m3.054s
    3sys     0m1.593s
    

    PR branch:

    0$ time ./test/functional/feature_backwards_compatibility.py
    1real    0m5.541s
    2user    0m1.875s
    3sys     0m1.220s
    

14. 
    DrahtBot commented at 5:01 pm on February 24, 2022: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

15. DrahtBot added the label Needs rebase on Feb 24, 2022
16. 
    MarcoFalke commented at 5:06 pm on February 24, 2022: member

    24cec4b5c02e12cf0b6b56ba5055b8f5758627a5
17. MarcoFalke closed this on Feb 24, 2022

    ---

18. MarcoFalke deleted the branch on Feb 24, 2022
19. DrahtBot locked this on Feb 24, 2023

Contributors
MarcoFalke DrahtBot Sjors theStack

Labels
Tests Needs rebase