test: Refactor tests using restart_node #19350

pull ccdle12 wants to merge 1 commits into bitcoin:master from ccdle12:test-refactor-restart-node changing 13 files +25 −48
  1. ccdle12 commented at 10:46 AM on June 22, 2020: contributor

    fixes #19345

    This PR replaces consecutive calls to stop_node() and start_node() with restart_node() where appropriate in the functional tests.

    The commit messages are repetitive but focused on each file changed with the intention of squashing if applicable.

  2. fanquake added the label Tests on Jun 22, 2020
  3. MarcoFalke commented at 10:56 AM on June 22, 2020: member

    There are less than 25 occurrences, so instead of 13 commits, I think this could be a single commit

  4. ccdle12 commented at 11:02 AM on June 22, 2020: contributor

    There are less than 25 occurrences, so instead of 13 commits, I think this could be a single commit

    Thanks, I'll squash them

  5. ccdle12 force-pushed on Jun 22, 2020
  6. test: refactor functional tests to use restart_node 20b6e95944
  7. DrahtBot commented at 1:50 PM on June 22, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19013 (test: add v0.20.0 to backwards compatibility test by Sjors)
    • #18554 (wallet: ensure wallet files are not reused across chains by mrwhythat)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. laanwj commented at 4:18 PM on June 22, 2020: member

    Checked (with git grep -C3 stop_node\() that none of the remaining uses of stop_node(x) is trivially followed by start_node(x). ACK 20b6e959449d0c07639599b99ba917d2cac62493

  9. laanwj merged this on Jun 22, 2020
  10. laanwj closed this on Jun 22, 2020

  11. Fabcien referenced this in commit ee9e2a2ee6 on Apr 21, 2021
  12. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me