This adds static_assert's that ensure that the default values given for fee levels in the wallet (minimum fee and incremental feerate increase) are at least as high as the corresponding levels configured in the core node policy. Since the core policy values are enforced by the network, it makes sense for the wallet to be conservative and above (or at least not below) this.
Static asserts for consistency of fee defaults #19370
pull domob1812 wants to merge 1 commits into bitcoin:master from domob1812:fee-asserts changing 1 files +5 −0-
domob1812 commented at 9:48 AM on June 24, 2020: contributor
-
1554b54d47
Static asserts for consistency of fee defaults.
This adds static asserts that ensure that the default values given for fee levels in the wallet (minimum fee and incremental feerate increase) are at least as high as the corresponding levels configured in the core node policy.
- fanquake added the label Tests on Jun 24, 2020
-
laanwj commented at 3:37 PM on July 22, 2020: member
code review ACK 1554b54d47d7e24ce2491f57d24e56d38ceb7649, these assumptions seem straightforward
- laanwj merged this on Jul 22, 2020
- laanwj closed this on Jul 22, 2020
- domob1812 deleted the branch on Jul 23, 2020
- sidhujag referenced this in commit 39eaa9602c on Jul 24, 2020
- domob1812 referenced this in commit 3eeaeae072 on Jul 27, 2020
- domob1812 referenced this in commit 7480f4e98c on Jul 27, 2020
- PastaPastaPasta referenced this in commit bb28bb3b80 on Jun 27, 2021
- PastaPastaPasta referenced this in commit ff65cfc6b4 on Jun 28, 2021
- PastaPastaPasta referenced this in commit c9a6604f4f on Jun 29, 2021
- DrahtBot locked this on Feb 15, 2022