Update pruning tooltip #19416

pull BitcoinErrorLog wants to merge 1 commits into bitcoin:master from BitcoinErrorLog:patch-1 changing 1 files +1 −1
  1. BitcoinErrorLog commented at 4:53 AM on June 30, 2020: first_time_contributor

    This tooltip is a bit confusing and a deterrent more than informative. Can we adjust to something that fits a user looking for a way to save disk space?

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Update pruning tooltip
    This tooltip is a bit confusing and a deterrent more than informative. Can we adjust to something that fits a user looking for a way to save disk space?
    5111e75df6
  3. DrahtBot added the label GUI on Jun 30, 2020
  4. hebasto commented at 5:13 AM on June 30, 2020: member

    @BitcoinErrorLog Welcome!

    Mind placing this PR into the dedicated repo https://github.com/bitcoin-core/gui ? See #19071.

  5. BitcoinErrorLog commented at 7:17 AM on June 30, 2020: none

    Done!

  6. hebasto commented at 7:20 AM on June 30, 2020: member

    Done!

    Thanks! And this PR could be closed now :) Ref: https://github.com/bitcoin-core/gui/pull/15

  7. fanquake closed this on Jun 30, 2020

  8. fanquake locked this on Jul 10, 2020
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me