Fix boost/C++17 compile failures #19428

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2007-boostCompileFail changing 2 files +2 −2

MarcoFalke commented at 9:28 PM on July 1, 2020: member

Compiling with C++17 enabled, but not the latest version of boost (e.g. 1.69) will result in a compile failure. I know that C++17 is not "officially" supported yet, especially not with all boost versions, since C++17 is meant to replace boost, but some of my systems can no longer compile Bitcoin Core and upstreaming the patches avoids others running into the same issue.

script: Fix boost/C++17 compile failure

script/standard.cpp:297:48: error: temporary of type 'boost::static_visitor<CScript>' has protected destructor
    return boost::apply_visitor(CScriptVisitor{}, dest);
                                               ^
/usr/include/boost/variant/static_visitor.hpp:53:5: note: declared protected here
    ~static_visitor() = default;
    ^
1 error generated.

fac7bdb75e

wallet: Replace boost::none with nullopt fa575f3461
MarcoFalke added the label Refactoring on Jul 1, 2020
sipa commented at 9:40 PM on July 1, 2020: member

utACK fa575f34614f189d5b083d7efa6925d968f4df11
MarcoFalke merged this on Jul 1, 2020
MarcoFalke closed this on Jul 1, 2020
MarcoFalke deleted the branch on Jul 1, 2020
kittywhiskers referenced this in commit 1bc3b60c44 on Jul 15, 2021
kittywhiskers referenced this in commit 22ca196aaa on Jul 17, 2021
Fabcien referenced this in commit 62401bcf2f on Aug 30, 2021
kittywhiskers referenced this in commit 866ceee037 on Sep 11, 2021
kittywhiskers referenced this in commit f9505c7133 on Sep 15, 2021
thelazier referenced this in commit bafc48fbfb on Sep 19, 2021
thelazier referenced this in commit 74fcadbbc9 on Sep 25, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

MarcoFalke

sipa

Labels

Refactoring