refactor: reduce DefaultRequestHandler memory allocations #19453

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:cli-reduce-memory-allocations changing 1 files +5 −5

jonatack commented at 1:48 AM on July 6, 2020: member

per #16439 (review). Simpler code, fewer allocations. No change of behavior. The code has good test coverage in interface_bitcoin_cli.py.
cli: reduce DefaultRequestHandler memory allocations f20b359bb9
fanquake added the label Refactoring on Jul 6, 2020
MarcoFalke commented at 10:59 AM on July 6, 2020: member

review ACK f20b359bb9dabc7be11c3e3319e435aa42a8f0f5
fjahr commented at 7:39 PM on July 10, 2020: member

Code review ACK f20b359

Could have even changed ConnectAndCallRPC to take a reference instead of the pointer to make it more clean but smaller change is good as well.
MarcoFalke merged this on Jul 10, 2020
MarcoFalke closed this on Jul 10, 2020
jonatack deleted the branch on Jul 11, 2020
jonatack commented at 5:23 AM on July 11, 2020: member

Code review ACK f20b359

Could have even changed ConnectAndCallRPC to take a reference instead of the pointer to make it more clean but smaller change is good as well.

Thanks! (Please review #16439; I think it's a useful user-facing feature.)
sidhujag referenced this in commit 99d5ee549e on Jul 11, 2020
Fabcien referenced this in commit 28f40cef17 on Aug 31, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels