build: Only use @ prefix for echo command in Makefiles #19480

1. 
   freenancial commented at 0:21 am on July 10, 2020: contributor

   According to #18891:

   … using @-prefix only when we’re @echo-ing.

   I searched all \t@ in all Makefile.am, and replaced the @ sign with $(AM_V_at) when it isn’t used on an echo command.

   ---

   This is my first Bitcoin PR, please let me know if I missed anything. Thanks a lot!

2. fanquake added the label Build system on Jul 10, 2020
3. 
   theuni commented at 0:48 am on July 10, 2020: member

   @ is used to avoid printing build steps, most of which are pretty spammy. I’m not a fan of this wholesale replacement.

   The makefile guidance in #18891 doesn’t apply to us IMO, as automake has its own $(AM_V_at) that is preferred over @. That keeps make quiet, but make V=1 print steps.

   So I think we should replace @ with $(AM_V_at) instead.

4. 
   DrahtBot commented at 2:19 am on July 10, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18980 (build: Decouple clientversion.cpp from the git repo by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. fanquake added the label Waiting for author on Jul 17, 2020
6. freenancial force-pushed on Jul 21, 2020
7. freenancial force-pushed on Jul 21, 2020
8. build: Only use `@` prefix for `echo` command in Makefile cb75c6c4b0
9. freenancial force-pushed on Jul 21, 2020
10. fanquake removed the label Waiting for author on Jul 21, 2020
11. 
    freenancial commented at 5:39 am on July 21, 2020: contributor

    @theuni , I have updated the PR to use $(AM_V_at) instead, and looks like all checks have been passed. PTAL at your convenience, thx!
12. 
    hebasto commented at 11:52 am on July 21, 2020: member

    automake manual:

    • You can use the predefined variable … AM_V_at as a prefix to commands that should not output anything in silent mode. When output is to be verbose, [this variable] will expand to the empty string.
    • You can silence a recipe unconditionally with @…

    Since the silent rules are enabled: https://github.com/bitcoin/bitcoin/blob/65a54d684fcfa5b2cb15b09fd9be9acb56bb5f79/configure.ac#L51-L52

    the using of the AM_V_at variable won’t have any effect.

    If more output is really needed in the verbose mode @ could be just removed (in justified cases).

13. 
    freenancial commented at 3:13 am on July 27, 2020: contributor

    I find I don’t have enough understanding about “automake” to continue with this PR, so I’m closing it. Anyone who is interested is welcome to commandeer it :)
14. freenancial closed this on Jul 27, 2020

    ---

15. fanquake added the label Up for grabs on Jul 27, 2020
16. DrahtBot locked this on Feb 15, 2022

Contributors
freenancial theuni DrahtBot hebasto

Labels
Build system Up for grabs