Refactor mempool.dat to be extensible, and store missing info #19488

1. 
   luke-jr commented at 3:52 am on July 11, 2020: member

   Rebased #9422

   At the time, we decided it wasn’t worth the effort to just store the mempool min fee, but now we want to add unbroadcast txids (#18807) so it seems like a good time to upgrade the format to be extensible.

   TODO: Update or remove test/functional/mempool_compatibility.py (not clear how to handle this)

2. fanquake added the label Mempool on Jul 11, 2020
3. 
   DrahtBot commented at 10:36 am on July 11, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19872 (Avoid locking CTxMemPool::cs recursively in some cases by hebasto)
   • #19438 (Introduce deploymentstatus by ajtowns)
   • #19381 (Fix UBSan warnings triggered when loading corrupt mempool.dat files by rajarshimaitra)
   • #19339 (validation: re-delegate absurd fee checking from mempool to clients by gzhao408)
   • #19259 (tests: Add fuzzing harness for LoadMempool(…) and DumpMempool(…) by practicalswift)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Needs rebase on Jul 22, 2020
5. Refactor {Dump,Load}Mempool to be more extensible b289164292
6. Store mempool min fee state in mempool.dat 1befffc0b4
7. luke-jr force-pushed on Jul 29, 2020
8. DrahtBot removed the label Needs rebase on Jul 29, 2020
9. 
   DrahtBot commented at 0:14 am on September 16, 2020: member

   🐙 This pull request conflicts with the target branch and needs rebase.

   Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

10. DrahtBot added the label Needs rebase on Sep 16, 2020
11. 
    luke-jr commented at 4:53 pm on November 20, 2020: member

    This missed 0.21, so probably no point in continuing further for now… Can reopen later when/if it becomes relevant again.
12. luke-jr closed this on Nov 20, 2020

    ---

13. DrahtBot locked this on Feb 15, 2022

Contributors
luke-jr DrahtBot

Labels
Mempool Needs rebase