Rpc send feereason #19497

pull stackman27 wants to merge 45 commits into bitcoin:master from stackman27:rpc_send_feereason changing 9 files +270 −18
  1. stackman27 commented at 9:10 PM on July 11, 2020: contributor

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Attempted test where one node sends block to another 0e95a6f508
  3. Merge pull request #2 from saahilshangle/practice-testing
    Attempted test where one node sends block to another
    1341bd0f31
  4. [rpc] return feereason from send* wallet rpcs 446128ec09
  5. [test] test send* wallet rpcs with verbose=True 7d9e5a135a
  6. Attempted test where one node sends block to another 5e95110915
  7. refactor: Extract GetBogoSize function a9389535fd
  8. rpc: gettxoutsetinfo can specify hash_type (only legacy option for now) 8eb28f0c2f
  9. rpc: Add hash_type NONE to gettxoutsetinfo 5b1c1837f1
  10. Replace automatic bans with discouragement filter
    This patch improves performance and resource usage around IP
addresses that are banned for misbehavior. They're already not
actually banned, as connections from them are still allowed,
but they are preferred for eviction if the inbound connection
slots are full.

Stop treating these like manually banned IP ranges, and instead
just keep them in a rolling Bloom filter of misbehaving nodes,
which isn't persisted to disk or exposed through the ban
framework. The effect remains the same: preferred for eviction,
avoided for outgoing connections, and not relayed to other peers.

Also change the name of this mechanism to better reflect reality;
they're not banned, just discouraged.

Contains release notes and several interface improvements by
John Newbery.
    a8251921c0
  11. Clean up separated ban/discourage interface 4aac3113aa
  12. wallet: Remove confusing double return value ret+success
    Also, remove redundant comments
    5e1dffaca6
  13. wallet: Replace CDataStream& with CDataStream&& where appropriate
    The keys and values are only to be used once because their memory is set
to zero. Make that explicit by moving the bytes into the lower level
methods.
    75d1f5aedc
  14. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    e3f074c4b3
  15. Attempted test where one node sends block to another 2adee2ff32
  16. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    b212fc2852
  17. Attempted test where one node sends block to another f1c8f7312f
  18. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    5e9a537112
  19. Attempted test where one node sends block to another 0ca6323a50
  20. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    0c54937c3b
  21. Revert "[test] test send* wallet rpcs with verbose=True"
    This reverts commit d8da095378c307052610119ea207a929ba441685.
    c49cc6aa92
  22. Fixed Master Merge Conflict b19cf05691
  23. [test] test send* wallet rpcs with verbose=True 080e8fceeb
  24. Attempted test where one node sends block to another 89725bc073
  25. refactor: Extract GetBogoSize function 5f4c15225a
  26. rpc: gettxoutsetinfo can specify hash_type (only legacy option for now) 4d4c91169a
  27. Replace automatic bans with discouragement filter
    This patch improves performance and resource usage around IP
addresses that are banned for misbehavior. They're already not
actually banned, as connections from them are still allowed,
but they are preferred for eviction if the inbound connection
slots are full.

Stop treating these like manually banned IP ranges, and instead
just keep them in a rolling Bloom filter of misbehaving nodes,
which isn't persisted to disk or exposed through the ban
framework. The effect remains the same: preferred for eviction,
avoided for outgoing connections, and not relayed to other peers.

Also change the name of this mechanism to better reflect reality;
they're not banned, just discouraged.

Contains release notes and several interface improvements by
John Newbery.
    b538370faf
  28. Clean up separated ban/discourage interface 7c9905669a
  29. wallet: Remove confusing double return value ret+success
    Also, remove redundant comments
    d0f2439e64
  30. wallet: Replace CDataStream& with CDataStream&& where appropriate
    The keys and values are only to be used once because their memory is set
to zero. Make that explicit by moving the bytes into the lower level
methods.
    75f7df8968
  31. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    c2430af280
  32. Attempted test where one node sends block to another bb4b32abd5
  33. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    d595cb8af6
  34. Attempted test where one node sends block to another 657e05697f
  35. refactor: Extract GetBogoSize function 54d5440f93
  36. rpc: gettxoutsetinfo can specify hash_type (only legacy option for now) 8c738e7cb8
  37. rpc: Add hash_type NONE to gettxoutsetinfo c20f46ea7d
  38. Replace automatic bans with discouragement filter
    This patch improves performance and resource usage around IP
addresses that are banned for misbehavior. They're already not
actually banned, as connections from them are still allowed,
but they are preferred for eviction if the inbound connection
slots are full.

Stop treating these like manually banned IP ranges, and instead
just keep them in a rolling Bloom filter of misbehaving nodes,
which isn't persisted to disk or exposed through the ban
framework. The effect remains the same: preferred for eviction,
avoided for outgoing connections, and not relayed to other peers.

Also change the name of this mechanism to better reflect reality;
they're not banned, just discouraged.

Contains release notes and several interface improvements by
John Newbery.
    d050da7a78
  39. Clean up separated ban/discourage interface 624f3ee301
  40. wallet: Remove confusing double return value ret+success
    Also, remove redundant comments
    a1becd4446
  41. wallet: Replace CDataStream& with CDataStream&& where appropriate
    The keys and values are only to be used once because their memory is set
to zero. Make that explicit by moving the bytes into the lower level
methods.
    21181db595
  42. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    9a9afb25ae
  43. Attempted test where one node sends block to another 805e632994
  44. Revert "Attempted test where one node sends block to another"
    This reverts commit 55cf78aae878ac1e2a8ed5712877465a2e4a938c.
    28910e7139
  45. Revert "[test] test send* wallet rpcs with verbose=True"
    This reverts commit d8da095378c307052610119ea207a929ba441685.
    61a7f86f17
  46. Merge pull request #6 from BerkeleyBlockchain/master
    send rpc return fee reason
    a5c1cea195
  47. stackman27 closed this on Jul 11, 2020
  48. fanquake locked this on Jul 11, 2020
Contributors
stackman27
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me