p2p: banscore updates to gui, tests, release notes #19512

1. 
   jonatack commented at 8:14 am on July 14, 2020: member

   This is the third -banscore PR in the mini-series described in #19464. See that PR for the intention and reasoning.

   • no longer display “Ban Score” in the GUI peers window and add a release note, plus release note fixups per #19464#pullrequestreview-447452052
   • update tests (src/test/denialofservice_tests.cpp and test/functional/p2p_leak.py) from banning to discouragement and per #19464 (comment)
2. gui, doc: rm Ban Score in GUI Peers window/release notes updates 1a9f462caa
3. in doc/release-notes.md:310 in cbd77a1972 outdated

   303@@ -303,6 +304,11 @@ issue.
   304 GUI changes
   305 -----------
   306 
   307+- The GUI Peers window no longer displays a "Ban Score" field. This is part of
   308+  changes in 0.20.1 and in this release to the handling of misbehaving
   309+  peers. Refer to "Changes regarding misbehaving peers" in the 0.20.1 release
   310+  notes for details. (#19510)
   

   ---

   ---

   

   jonatack commented at 8:15 am on July 14, 2020:

   s/19510/19512/
4. MarcoFalke added the label P2P on Jul 14, 2020
5. MarcoFalke added this to the milestone 0.21.0 on Jul 14, 2020
6. jonatack force-pushed on Jul 14, 2020
7. 
   jnewbery commented at 8:53 am on July 14, 2020: member

   code review ACK 38cc0003812dbc7199bc00f5801f7ddb9ec89e37.

   I think we should also remove -bantime, DEFAULT_MISBEHAVING_BANTIME, m_default_ban_time and the default time argument to Banman::Ban() now as well. Since Ban() can now only be called from the RPC or GUI, the user can provide a bantime on each call (with a default provided by RPC/GUI).

8. test: update tests for peer discouragement fa108d6a75
9. jonatack force-pushed on Jul 14, 2020
10. 
    jonatack commented at 12:22 pm on July 14, 2020: member

    Thanks for reviewing @jnewbery. Updated the second commit to follow up on your suggestion at #19464 (comment).

    git diff 38cc000 fa108d6

11. 
    jonatack commented at 12:25 pm on July 14, 2020: member

    I think we should also remove -bantime, DEFAULT_MISBEHAVING_BANTIME, m_default_ban_time and the default time argument to Banman::Ban() now as well. Since Ban() can now only be called from the RPC or GUI, the user can provide a bantime on each call (with a default provided by RPC/GUI).

    You know how I love removing code. Will have a look for a follow-up.

12. 
    jnewbery commented at 12:35 pm on July 14, 2020: member

    ACK fa108d6a757838225179a8df942cfb6d99c98c90
13. jonatack renamed this:
    gui, doc, test: banscore updates to gui, release notes, p2p_leak test
    p2p: banscore updates to gui, tests, release notes
    on Jul 14, 2020
14. 
    DrahtBot commented at 3:25 pm on July 14, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #19134 (test: Replace global wait_until with BitcoinTestFramework.wait_until and mininode.wait_until by dboures)
    • #17785 (p2p: Unify Send and Receive protocol versions by hebasto)
    • #17479 (Return BlockValidationState from ProcessNewBlock if CheckBlock/AcceptBlock fails by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

15. 
    laanwj commented at 2:32 pm on July 15, 2020: member

    ACK fa108d6a757838225179a8df942cfb6d99c98c90 Did code review and tested the GUI change.
16. laanwj merged this on Jul 15, 2020
17. laanwj closed this on Jul 15, 2020

    ---

18. jonatack deleted the branch on Jul 15, 2020
19. sidhujag referenced this in commit 9de76c71bf on Jul 16, 2020
20. deadalnix referenced this in commit 59fd163cc4 on Jan 6, 2021
21. DrahtBot locked this on Feb 15, 2022

Contributors
jonatack jnewbery DrahtBot laanwj

Labels
P2P

Milestone
0.21.0