[net/net processing] check banman pointer before dereferencing #19514

1. 
   jnewbery commented at 9:29 am on July 14, 2020: member

   Although we currently don’t do this, it should be possible to create a CConnman or PeerLogicValidation without a Banman instance. Therefore always check that banman exists before dereferencing the pointer.

   Also add comments to the m_banman members of CConnman and PeerLogicValidation to document that these may be nullptr.

2. [net/net processing] check banman pointer before dereferencing

   Although we currently don't do this, it should be possible to create a
   CConnman or PeerLogicValidation without a Banman instance. Therefore
   always check that banman exists before dereferencing the pointer.
   
   Also add comments to the m_banman members of CConnman and
   PeerLogicValidation to document that these may be nullptr.

   ca3585a483
3. 
   jnewbery commented at 9:30 am on July 14, 2020: member

   cc @theuni @sipa
4. 
   jonatack commented at 9:54 am on July 14, 2020: member

   ACK ca3585a
5. fanquake added the label P2P on Jul 14, 2020
6. MarcoFalke added the label Refactoring on Jul 14, 2020
7. theStack approved
8. 
   theStack commented at 11:54 am on July 14, 2020: member

   ACK https://github.com/bitcoin/bitcoin/commit/ca3585a483ca5f6fc4cc54fd1530f89d13e5b7b0
9. MarcoFalke merged this on Jul 14, 2020
10. MarcoFalke closed this on Jul 14, 2020

    ---

11. jnewbery deleted the branch on Jul 14, 2020
12. deadalnix referenced this in commit 651e316902 on Jan 6, 2021
13. DrahtBot locked this on Feb 15, 2022

Contributors
jnewbery jonatack theStack

Labels
Refactoring P2P