- if -datadir= is no directory don't return an empty path, but instead create / use the default data dir
- check for existance of the final datadir, before trying to create it
This should fix #1950.
prevent GetDataDir() from returning an empty path #1954
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:fix_datadir changing 1 files +8 −8-
Diapolo commented at 1:28 PM on October 24, 2012: none
-
3215150c9f
prevent GetDataDir() from returning an empty path
- if -datadir= is no directory don't return an empty path, but instead create / use the default data dir - check for existance of the final datadir, before trying to create it
-
sipa commented at 1:34 PM on October 24, 2012: member
If a -datadir is specified and there's a problem with it, you want to get an error, not a default.
-
Diapolo commented at 1:47 PM on October 24, 2012: none
Well that is indeed also true but just leads to the command-line parsing discussion and silent errors. Perhaps I missunderstood what is causing the crash ... it was bitcoind and seems to be caused by the Shutdown() call. I guess there is no need for this patch then ^^, sorry.
- Diapolo closed this on Oct 24, 2012
- KolbyML referenced this in commit 676f6a79bf on Dec 5, 2020
- DrahtBot locked this on Sep 8, 2021
