If multiple entries are possible, wrapping Type should be OBJ_DYN.
fixes #19579
rpc: RPCResult Type of MempoolEntryDescription should be OBJ. #19585
pull stylesuxx wants to merge 1 commits into bitcoin:master from stylesuxx:19579 changing 1 files +6 −6-
stylesuxx commented at 4:20 PM on July 24, 2020: contributor
-
rpc: RPCResult Type of MempoolEntryDescription should be OBJ. If multiple entries are possible, wrapping Type should be OBJ_DYN. fixes #19579 ae4958be95
-
MarcoFalke commented at 7:59 AM on July 25, 2020: member
OBJ vs OBJ_DYN tells whether the keys are static string literals ore dynamic run-time strings. I.e
{ "txid" : "$runtime_hex" } # OBJ { "$runtime_hex" : 1337 } # OBJ_DYNSo the diff looks correct. Concept ACK
-
promag commented at 10:32 AM on July 26, 2020: member
I've missed this detail, didn't fully review #17809. So only difference is this https://github.com/bitcoin/bitcoin/pull/17809/files#diff-a2c210f0004fc59cf7e73a29076dd7a8R660 right?
-
MarcoFalke commented at 10:50 AM on July 26, 2020: member
So only difference is ...
Jup
-
promag commented at 10:54 AM on July 26, 2020: member
ACK
- DrahtBot added the label RPC/REST/ZMQ on Jul 26, 2020
-
MarcoFalke commented at 5:50 AM on July 31, 2020: member
Rendered diff:
diff --git a/getmempoolancestors b/getmempoolancestors index c0710e1..1d4e56c 100644 --- a/getmempoolancestors +++ b/getmempoolancestors @@ -42,8 +42,7 @@ Result (for verbose = true): ... ], "bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee) - "unbroadcast" : true|false, (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) - ... + "unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) } Examples: diff --git a/getmempooldescendants b/getmempooldescendants index 02512ac..43be4fc 100644 --- a/getmempooldescendants +++ b/getmempooldescendants @@ -43,9 +43,9 @@ Result (for verbose = true): ... ], "bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee) - "unbroadcast" : true|false, (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) - ... - } + "unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) + }, + ... } Examples: diff --git a/getmempoolentry b/getmempoolentry index 18ba2f1..2b66128 100644 --- a/getmempoolentry +++ b/getmempoolentry @@ -35,8 +35,7 @@ Result: ... ], "bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee) - "unbroadcast" : true|false, (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) - ... + "unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) } Examples: diff --git a/getrawmempool b/getrawmempool index 0323e3e..edcdf20 100644 --- a/getrawmempool +++ b/getrawmempool @@ -44,9 +44,9 @@ Result (for verbose = true): ... ], "bip125-replaceable" : true|false, (boolean) Whether this transaction could be replaced due to BIP125 (replace-by-fee) - "unbroadcast" : true|false, (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) - ... - } + "unbroadcast" : true|false (boolean) Whether this transaction is currently unbroadcast (initial broadcast not yet acknowledged by any peers) + }, + ... } Examples: - MarcoFalke merged this on Jul 31, 2020
- MarcoFalke closed this on Jul 31, 2020
- sidhujag referenced this in commit 9299f18d4b on Jul 31, 2020
- Fabcien referenced this in commit 7dacaa4fc7 on Sep 6, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels