Most of the rpc commands that take a number of blocks as an argument have an argument name of nblocks, like:
but generatetodescriptor instead has an argument name of num_blocks.
Not sure if I am being to pedantic here, but I'll happily provide a PR.
Changing the naming would be a breaking change
@MarcoFalke - I am not sure if I understand why it would be a breaking change - maybe I was not completely clear: https://github.com/bitcoin/bitcoin/blob/2f71a1ea35667b3873197201531e7ae198ec5bf4/src/rpc/mining.cpp#L209 vs. https://github.com/bitcoin/bitcoin/blob/2f71a1ea35667b3873197201531e7ae198ec5bf4/src/rpc/mining.cpp#L244
Within the code itself both methods use num_blocks, which can stay as it is. And the RPC arguments are all positional, not named - right?
Both, positional as well as named args are supported
Oh, I missed that. Then of course it makes no sense to change that.
Yes, RPC API changes usually need to go through a deprecation process. Run git log -S deprecat for an idea.
I see, thanks for the heads up, I guess this issue can be closed then.