rpc: Document getwalletinfo’s unlocked_until field as optional #19634

pull justinmoon wants to merge 1 commits into bitcoin:master from justinmoon:getwalletinfo changing 1 files +1 −1
  1. justinmoon commented at 5:35 pm on July 31, 2020: contributor
    The getwalletinfo RPC command’s unlocked_until field is optional in the code, but wasn’t marked as optional in the docs.
  2. rpc: Document getwalletinfo's unlocked_until field as optional f916847d2b
  3. luke-jr approved
  4. luke-jr commented at 7:28 pm on July 31, 2020: member
    utACK
  5. DrahtBot added the label RPC/REST/ZMQ on Jul 31, 2020
  6. DrahtBot added the label Wallet on Jul 31, 2020
  7. theStack commented at 3:36 pm on August 2, 2020: member

    ACK https://github.com/bitcoin/bitcoin/pull/19634/commits/f916847d2b56f2935c169e1b95b350a477c804cc

    Affected help line on master branch ($ src/bitcoin-cli -testnet help getwalletinfo | grep unlocked_until): "unlocked_until" : xxx, (numeric) the UNIX epoch time until which the wallet is unlocked for transfers, or 0 if the wallet is locked

    Affected help line on PR branch: "unlocked_until" : xxx, (numeric, optional) the UNIX epoch time until which the wallet is unlocked for transfers, or 0 if the wallet is locked (only present for passphrase-encrypted wallets)

  8. achow101 commented at 3:52 pm on August 2, 2020: member
    ACK f916847d2b56f2935c169e1b95b350a477c804cc
  9. kristapsk approved
  10. kristapsk commented at 0:09 am on August 4, 2020: contributor
    ACK f916847d2b56f2935c169e1b95b350a477c804cc
  11. fanquake merged this on Aug 4, 2020
  12. fanquake closed this on Aug 4, 2020

  13. sidhujag referenced this in commit 712849c8e0 on Aug 4, 2020
  14. meshcollider referenced this in commit 609ce2d0da on Aug 13, 2020
  15. sidhujag referenced this in commit 166c599bf8 on Aug 14, 2020
  16. deadalnix referenced this in commit 650a45afbc on Sep 7, 2021
  17. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me