rpc: Document getwalletinfo's unlocked_until field as optional #19634

pull justinmoon wants to merge 1 commits into bitcoin:master from justinmoon:getwalletinfo changing 1 files +1 −1

justinmoon commented at 5:35 PM on July 31, 2020: contributor

The getwalletinfo RPC command's unlocked_until field is optional in the code, but wasn't marked as optional in the docs.
rpc: Document getwalletinfo's unlocked_until field as optional f916847d2b
luke-jr approved
luke-jr commented at 7:28 PM on July 31, 2020: member

utACK
DrahtBot added the label RPC/REST/ZMQ on Jul 31, 2020
DrahtBot added the label Wallet on Jul 31, 2020
theStack commented at 3:36 PM on August 2, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/19634/commits/f916847d2b56f2935c169e1b95b350a477c804cc

Affected help line on master branch ($ src/bitcoin-cli -testnet help getwalletinfo | grep unlocked_until): "unlocked_until" : xxx, (numeric) the UNIX epoch time until which the wallet is unlocked for transfers, or 0 if the wallet is locked

Affected help line on PR branch: "unlocked_until" : xxx, (numeric, optional) the UNIX epoch time until which the wallet is unlocked for transfers, or 0 if the wallet is locked (only present for passphrase-encrypted wallets)
achow101 commented at 3:52 PM on August 2, 2020: member

ACK f916847d2b56f2935c169e1b95b350a477c804cc
kristapsk approved
kristapsk commented at 12:09 AM on August 4, 2020: contributor

ACK f916847d2b56f2935c169e1b95b350a477c804cc
fanquake merged this on Aug 4, 2020
fanquake closed this on Aug 4, 2020
sidhujag referenced this in commit 712849c8e0 on Aug 4, 2020
meshcollider referenced this in commit 609ce2d0da on Aug 13, 2020
sidhujag referenced this in commit 166c599bf8 on Aug 14, 2020
deadalnix referenced this in commit 650a45afbc on Sep 7, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19644 rpc: document returned error fields as optional if applicable