lint: Don’t use TRAVIS_COMMIT_RANGE in commit message linter #19654

1. 
   fjahr commented at 0:00 am on August 4, 2020: member

   #19439 was recently merged and seemed to work fine but I now noticed strange behavior when it was running in Travis, which I could not reproduce locally. It turns out TRAVIS_COMMIT_RANGE which is used in Travis to get the commits for the linter, uses all the commits that were in a push, which includes all rebase commits for example. This means that the linter can fail on a commit that the developer has never even seen before, which can be very confusing. See an example here which caused me to look into this: https://travis-ci.org/github/bitcoin/bitcoin/jobs/714296381 The commit that is reported as failing in my PR is not part of my PR.

   I think we rather want to use something like git merge-base to get the commit range by default and in Travis. I am leaving the env variable functionality in place with a different name but this is not a variable that can be expected to be present in the CI environments so the merge-base range should be used there by default.

2. fanquake added the label Scripts and tools on Aug 4, 2020
3. fjahr renamed this:
   lint: Improve commit message linter in Travis
   lint: Don't use TRAVIS_COMMIT_RANGE in commit message linter
   on Aug 4, 2020
4. lint: Remove travis env var from commit linter 72351784b3
5. fjahr force-pushed on Aug 4, 2020
6. 
   hebasto commented at 6:19 pm on August 4, 2020: member

   Related: https://github.com/travis-ci/travis-ci/issues/4596
7. 
   hebasto commented at 6:21 pm on August 4, 2020: member

   Concept ACK on not relying on TRAVIS_COMMIT_RANGE.
8. MarcoFalke approved
9. 
   MarcoFalke commented at 7:34 am on August 5, 2020: member

   ACK
10. hebasto approved
11. 
    hebasto commented at 7:43 am on August 5, 2020: member

    ACK 72351784b3df21a89f79076f4b814a6e700b6469, I have reviewed the code and it looks OK, I agree it can be merged.
12. MarcoFalke merged this on Aug 5, 2020
13. MarcoFalke closed this on Aug 5, 2020

    ---

14. ryanofsky referenced this in commit 506b9cb095 on Aug 13, 2020
15. MarcoFalke referenced this in commit 06314fbb55 on Oct 4, 2020
16. PastaPastaPasta referenced this in commit 4941ab2a83 on Jun 27, 2021
17. PastaPastaPasta referenced this in commit a4e7a057d7 on Jun 28, 2021
18. PastaPastaPasta referenced this in commit 02ece69a88 on Jun 29, 2021
19. PastaPastaPasta referenced this in commit 006cd52e74 on Jul 1, 2021
20. PastaPastaPasta referenced this in commit eb6893fa01 on Jul 1, 2021
21. PastaPastaPasta referenced this in commit 731fc7a695 on Jul 15, 2021
22. PastaPastaPasta referenced this in commit fb7b4bbdca on Jul 16, 2021
23. DrahtBot locked this on Feb 15, 2022

Contributors
fjahr hebasto MarcoFalke

Labels
Scripts and tools