test: Wait until is_connected in add_p2p_connection #19657

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2008-testWaitConn changing 4 files +11 −14

MarcoFalke commented at 10:53 AM on August 4, 2020: member

Moving the wait_until from the individual test scripts to the test framework simplifies two tests
MarcoFalke added the label Tests on Aug 4, 2020
MarcoFalke commented at 10:54 AM on August 4, 2020: member

Suggested by @jnewbery here: https://github.com/bitcoin/bitcoin/pull/19489/files#r464387191
test: Wait until is_connected in add_p2p_connection fa4dfd215f
MarcoFalke force-pushed on Aug 4, 2020
theStack approved
theStack commented at 12:06 PM on August 6, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/19657/commits/fa4dfd215f62e88d668311701735c332c264fa2a :coffee: Code-reviewed, checked that all now redundant wait-for-connection constructs (wait_until(... .is_connected, ...)) after add_p2p_connection(...) in other tests were tackled and ran the functional tests locally.

in test/functional/p2p_leak.py:69 in fa4dfd215f

  62 | @@ -63,23 +63,20 @@ def on_cmpctblock(self, message): self.bad_message(message)
  63 |      def on_getblocktxn(self, message): self.bad_message(message)
  64 |      def on_blocktxn(self, message): self.bad_message(message)
  65 |  
  66 | +
  67 |  # Node that never sends a version. We'll use this to send a bunch of messages
  68 |  # anyway, and eventually get disconnected.
  69 |  class CNodeNoVersionMisbehavior(CLazyNode):

jnewbery commented at 12:58 PM on August 6, 2020:

Any reason not to remove this class entirely?

jnewbery commented at 12:59 PM on August 6, 2020: member

Concept ACK. One question inline
jnewbery commented at 1:27 PM on August 6, 2020: member

Code review ACK fa4dfd215f62e88d668311701735c332c264fa2a

We should consider removing CNodeNoVersionMisbehavior either here or in a follow-up.
laanwj merged this on Aug 9, 2020
laanwj closed this on Aug 9, 2020
sidhujag referenced this in commit 515565e008 on Aug 9, 2020
dhruv referenced this in commit 0b84f524ae on Aug 14, 2020
dhruv referenced this in commit 3908572af7 on Aug 14, 2020
MarcoFalke deleted the branch on Aug 14, 2020
dhruv referenced this in commit 079c255a52 on Aug 15, 2020
dhruv referenced this in commit 5a02e8c8a8 on Aug 15, 2020
dhruv referenced this in commit bee8ff0758 on Aug 17, 2020
dhruv referenced this in commit 33fdd2972e on Aug 17, 2020
fanquake referenced this in commit 70d7ddbcbb on Aug 20, 2020
sidhujag referenced this in commit 6a279b7519 on Aug 20, 2020
Fabcien referenced this in commit d6143c3436 on Sep 7, 2021
Fabcien referenced this in commit 85f7e0cf3f on Sep 7, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#19727 test: Remove unused classes from p2p_leak.py