0.20: Add txids with non-standard inputs to reject filter #19680

1. 
   sdaftuar commented at 3:32 pm on August 7, 2020: member

   Backport of #19620 to 0.20.
2. DrahtBot added the label P2P on Aug 7, 2020
3. DrahtBot added the label Tests on Aug 7, 2020
4. DrahtBot added the label TX fees and policy on Aug 7, 2020
5. DrahtBot added the label Validation on Aug 7, 2020
6. Add txids with non-standard inputs to reject filter

   Our policy checks for non-standard inputs depend only on the non-witness
   portion of a transaction: we look up the scriptPubKey of the input being
   spent from our UTXO set (which is covered by the input txid), and the p2sh
   checks only rely on the scriptSig portion of the input.
   
   Consequently it's safe to add txids of transactions that fail these checks to
   the reject filter, as the witness is irrelevant to the failure. This is helpful
   for any situation where we might request the transaction again via txid (either
   from txid-relay peers, or if we might fetch the transaction via txid due to
   parent-fetching of orphans).
   
   Further, in preparation for future witness versions being deployed on the
   network, ensure that WITNESS_UNKNOWN transactions are rejected in
   AreInputsStandard(), so that transactions spending v1 (or greater) witness
   outputs will fall into this category of having their txid added to the reject
   filter.
   
   Github-Pull: #19620
   Rebased-From: 7989901c7eb62ca28b3d1e5d5831041a7267e495

   06f9c5c3be
7. test addition of unknown segwit spends to txid reject filter

   Github-Pull: #19620
   Rebased-From: 9f88ded82b2898ca63d44c08072f1ba52f0e18d7

   107cf1515e
8. sdaftuar force-pushed on Aug 7, 2020
9. fanquake added the label Backport on Aug 7, 2020
10. 
    jnewbery commented at 9:22 am on August 11, 2020: member

    utACK 107cf1515e69ee773ad1bcc1d5b6fffa49b78750
11. MarcoFalke removed the label Backport on Aug 23, 2020
12. MarcoFalke removed the label P2P on Aug 23, 2020
13. MarcoFalke removed the label TX fees and policy on Aug 23, 2020
14. MarcoFalke removed the label Tests on Aug 23, 2020
15. MarcoFalke removed the label Validation on Aug 23, 2020
16. DrahtBot added the label Backport on Aug 23, 2020
17. 
    instagibbs commented at 6:11 pm on August 24, 2020: member

    should this be added to 0.20.2 milestone?
18. 
    instagibbs commented at 6:15 pm on August 24, 2020: member

    utACK https://github.com/bitcoin/bitcoin/pull/19680/commits/107cf1515e69ee773ad1bcc1d5b6fffa49b78750
19. MarcoFalke added this to the milestone 0.20.2 on Aug 24, 2020
20. jnewbery added this to the "Blockers" column in a project

    ---

21. 
    fjahr commented at 2:48 pm on September 1, 2020: member

    utACK 107cf1515e69ee773ad1bcc1d5b6fffa49b78750

    Didn’t do full testing but briefly verified that the test fails if the behavior changes are undone.

22. fanquake merged this on Sep 4, 2020
23. fanquake closed this on Sep 4, 2020

    ---

24. fanquake removed this from the "Blockers" column in a project

    ---

25. DrahtBot locked this on Feb 15, 2022

Contributors
sdaftuar jnewbery instagibbs fjahr

Labels
Backport

Milestone
0.20.2