0.19: Add txids with non-standard inputs to reject filter #19681

1. 
   sdaftuar commented at 3:33 pm on August 7, 2020: member

   Backport of #19620 to 0.19.
2. DrahtBot added the label P2P on Aug 7, 2020
3. DrahtBot added the label Tests on Aug 7, 2020
4. DrahtBot added the label TX fees and policy on Aug 7, 2020
5. DrahtBot added the label Validation on Aug 7, 2020
6. sdaftuar force-pushed on Aug 7, 2020
7. sdaftuar force-pushed on Aug 7, 2020
8. sdaftuar force-pushed on Aug 7, 2020
9. fanquake added the label Backport on Aug 7, 2020
10. 
    laanwj commented at 2:50 pm on August 9, 2020: member

    As for the appveyor error I’m not sure I think you either need fae0e93836c0aa96b9274c69651b02cbf6352dc1 (#19444) and/or faf5e256c50a3fe5f946daeab3fe68a894caad95 (#18640).
11. sdaftuar force-pushed on Aug 10, 2020
12. 
    sdaftuar commented at 5:38 pm on August 10, 2020: member

    Just tried to backport #19444 but not sure I did it right…
13. 
    jnewbery commented at 9:23 am on August 11, 2020: member

    We should merge #19025 rather than include appveyor changes in this PR.
14. 
    jnewbery commented at 9:26 am on August 11, 2020: member

    utACK the last two commits in 568007cffe0c3998d5b4b20e16d4ae6fb779ed43
15. DrahtBot added the label Needs rebase on Aug 11, 2020
16. Add txids with non-standard inputs to reject filter

    Our policy checks for non-standard inputs depend only on the non-witness
    portion of a transaction: we look up the scriptPubKey of the input being
    spent from our UTXO set (which is covered by the input txid), and the p2sh
    checks only rely on the scriptSig portion of the input.
    
    Consequently it's safe to add txids of transactions that fail these checks to
    the reject filter, as the witness is irrelevant to the failure. This is helpful
    for any situation where we might request the transaction again via txid (either
    from txid-relay peers, or if we might fetch the transaction via txid due to
    parent-fetching of orphans).
    
    Further, in preparation for future witness versions being deployed on the
    network, ensure that WITNESS_UNKNOWN transactions are rejected in
    AreInputsStandard(), so that transactions spending v1 (or greater) witness
    outputs will fall into this category of having their txid added to the reject
    filter.
    
    Github-Pull: #19620
    Rebased-From: 7989901c7eb62ca28b3d1e5d5831041a7267e495

    2ea826cfc4
17. test addition of unknown segwit spends to txid reject filter

    Github-Pull: #19620
    Rebased-From: 9f88ded82b2898ca63d44c08072f1ba52f0e18d7

    52c3bec1ba
18. sdaftuar force-pushed on Aug 11, 2020
19. DrahtBot removed the label Needs rebase on Aug 11, 2020
20. MarcoFalke removed the label Tests on Aug 23, 2020
21. MarcoFalke removed the label Backport on Aug 23, 2020
22. MarcoFalke removed the label P2P on Aug 23, 2020
23. MarcoFalke removed the label TX fees and policy on Aug 23, 2020
24. MarcoFalke removed the label Validation on Aug 23, 2020
25. DrahtBot added the label Backport on Aug 23, 2020
26. 
    instagibbs commented at 6:15 pm on August 24, 2020: member

    utACK https://github.com/bitcoin/bitcoin/pull/19681/commits/52c3bec1bad4fc602a3911b44de48c6b0dbdfd25
27. MarcoFalke added this to the milestone 0.19.2 on Aug 24, 2020
28. 
    jnewbery commented at 7:20 pm on August 24, 2020: member

    utACK 52c3bec1ba
29. jonasschnelli approved
30. 
    jonasschnelli commented at 7:07 am on August 28, 2020: contributor

    utACK 52c3bec1bad4fc602a3911b44de48c6b0dbdfd25 Compared with #19620
31. jonasschnelli merged this on Aug 28, 2020
32. jonasschnelli closed this on Aug 28, 2020

    ---

33. MarkLTZ referenced this in commit e7c1c42d59 on Nov 8, 2020
34. DrahtBot locked this on Feb 15, 2022

Contributors
sdaftuar laanwj jnewbery instagibbs jonasschnelli

Labels
Backport

Milestone
0.19.2