It seems slightly confusing to have a default value for the connection type when all call sites specify the type. (Same for the other removed default values)
Also, clang-format includes and empty lines.
net: Remove unused conn_type default arg in OpenNetworkConnection #19707
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1908-netDefault changing 1 files +6 −8-
MarcoFalke commented at 7:01 AM on August 13, 2020: member
-
net: Remove unused conn_type default arg in OpenNetworkConnection fa19fb194b
- fanquake added the label P2P on Aug 13, 2020
- MarcoFalke added the label Refactoring on Aug 13, 2020
-
jnewbery commented at 7:44 AM on August 13, 2020: member
-
MarcoFalke commented at 11:34 AM on August 13, 2020: member
Ah thx
- MarcoFalke closed this on Aug 13, 2020
- MarcoFalke deleted the branch on Aug 13, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels