ci: Set increased --timeout-factor by default #19730

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2008-ciTimeoutDefault changing 6 files +9 −7

MarcoFalke commented at 7:25 AM on August 15, 2020: member

Assuming that tests don't have a logic error or race, setting a high timeout should not cause any issues. The tests will still pass just as fast in the fastest case, but it allows for some buffer in case of slow disks or otherwise starved ci machines.

Fixes #19729
ci: Set increased --timeout-factor by default fa6583c30b
DrahtBot added the label Tests on Aug 15, 2020
hebasto commented at 9:37 AM on August 15, 2020: member

Fixes #19729

The failed job already has --timeout-factor=4. Maybe the default value should be increased?
test: Remove confusing and broken use of wait_until global fa330ec2fe
MarcoFalke commented at 12:03 PM on August 15, 2020: member

Eh, the traceback says 60 seconds (https://cirrus-ci.com/task/4981335074799616?command=ci#L2004), which is the hardcoded default value. Fixed the wallet_basic bug in a new commit.
hebasto approved
hebasto commented at 1:02 PM on August 15, 2020: member

ACK fa330ec2fe5f5ba68a8d43fff0b19584c0b1ff39, I have reviewed the code, and it looks OK, I agree it can be merged.

There are other test_framework.util.wait_until() calls with default timeout_factor=1.0 in the code. I think they should be investigated to see if they are being used correctly.

UPDATED: Missed #19080
MarcoFalke merged this on Aug 15, 2020
MarcoFalke closed this on Aug 15, 2020
MarcoFalke deleted the branch on Aug 16, 2020
deadalnix referenced this in commit 0128eccd01 on Sep 15, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

MarcoFalke

hebasto

Labels

Tests

Linked (view graph)

#19729 test: Intermittent "no RPC connection" in wallet_basic.py --descriptors