wallet: restore condition for HD chain split upgrade #19747

pull S3RK wants to merge 1 commits into bitcoin:master from S3RK:wallet_upgrade_fix changing 1 files +1 −1

S3RK commented at 11:43 am on August 17, 2020: member

Rationale: restore condition that prevents multiple upgrades to HD chain split
wallet: restore condition for HD chain split upgrade 312474c2e6
fanquake added the label Wallet on Aug 17, 2020
achow101 commented at 3:51 pm on August 17, 2020: member

ACK 312474c2e69dc0ff32b570c76e437d2317121118

Nice catch. How does this mistake keep sneaking back in? I thought I fixed it in the initial PR.
MarcoFalke commented at 4:53 pm on August 17, 2020: member

This breaks the test. Does this need backport?
achow101 commented at 5:01 pm on August 17, 2020: member

I think #18836 actually fixes this problem (in a different way) and also has a variety of other fixes and updated tests. It may be better to review that.
DrahtBot commented at 8:11 pm on August 20, 2020: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18836 (wallet: upgradewallet fixes and additional tests by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
S3RK commented at 8:08 am on August 21, 2020: member

Closed in favor of #18836
S3RK closed this on Aug 21, 2020
S3RK deleted the branch on Oct 15, 2020
DrahtBot locked this on Feb 15, 2022

Labels
Wallet