filesystem.hpp and thread.hpp are included in util.h, which is included in util.cpp
remove 2 unneeded includes from util.cpp that are in the .h #1976
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:rem_unneeded_inc changing 1 files +0 −2-
Diapolo commented at 10:23 AM on November 4, 2012: none
-
remove 2 unneeded includes from util.cpp that are in the .h 5b28f9261b
-
laanwj commented at 11:08 AM on November 4, 2012: member
It's too bad all this stuff needs to be included in the headers
-
BitcoinPullTester commented at 10:34 PM on November 4, 2012: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5b28f9261b93c03a833a4f693b1123192d9c349d for binaries and test log.
-
sipa commented at 12:44 AM on November 5, 2012: member
Meh. Minimizing includes is nice, but specifying your direct dependencies is also nice, as it reduces problem when refactoring things...
-
robbak commented at 12:56 AM on November 5, 2012: contributor
Another point to remember- with other build systems, the order of includes can change. In freebsd we have to patch one of the source files, because the build system pulls in /usr/local/include/db4/db.h before is looks for ../db.h Sometimes, duplicate includes are needed. On 05/11/2012 10:45 AM, "Pieter Wuille" notifications@github.com wrote:
Meh. Minimizing includes is nice, but specifying your direct dependencies is also nice, as it reduces problem when refactoring things...
— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/1976#issuecomment-10057955.
-
- Diapolo closed this on Nov 10, 2012
- KolbyML referenced this in commit 9e3c70d34a on Dec 5, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors