The txs field is described as "The number of transactions (excluding coinbase)", yet it appears that it does includes the coinbase.
getblockstats's txs field is incorrectly documented as excluding the coinbase transaction #19766
issue shesek opened this issue on August 20, 2020-
shesek commented at 4:55 AM on August 20, 2020: contributor
- shesek added the label Bug on Aug 20, 2020
- MarcoFalke added the label RPC/REST/ZMQ on Aug 20, 2020
- MarcoFalke added the label Docs on Aug 20, 2020
-
MarcoFalke commented at 4:04 PM on August 20, 2020: member
Mind fixing up the documentation? This is the behaviour from when it was added:
$ git log -S 'all.pushKV("txs", (int64_t)block.vtx.si' commit 35e77a0288bcac5594ff25c10c9679a161cb730b Author: Jorge Timón <jtimon@jtimon.cc> Date: Sun Jun 4 00:25:55 2017 +0200 RPC: Introduce getblockstats - shesek referenced this in commit 4148f55dd0 on Aug 21, 2020
-
shesek commented at 2:45 PM on August 21, 2020: contributor
@MarcoFalke Sure, I sent #19777 with a fix. Just wanted to make sure that its the documentation that needs fixing and not the behavior.
- shesek closed this on Aug 21, 2020
- MarcoFalke referenced this in commit 197450f808 on Aug 22, 2020
- sidhujag referenced this in commit c9d718d3ae on Aug 23, 2020
- fanquake referenced this in commit 8bd2ab1f35 on Oct 14, 2020
- fanquake referenced this in commit 05bd0c220a on Oct 16, 2020
- MarkLTZ referenced this in commit 6fc6f538f6 on Nov 21, 2020
- MarcoFalke locked this on Feb 15, 2022
Contributors
Labels