Add HTTP REST, wget(1)-friendly crypted key dump via GET /wallet-ckeys.json #1982

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:http-backup changing 5 files +79 −0

jgarzik commented at 11:24 PM on November 4, 2012: contributor
See individual commits. This provides a slightly different, not-JSON-RPC API endpoint, which makes this HTTP request usable via "wget" and similar utilities.

The content returned and format thereof is certainly open to discussion.

My main goals were
- fix HTTP request line parsing bugs
- tighten HTTP request line validation, including "/" URI (our default JSON-RPC endpoint)
- permit dump of crypted keys, without decrypting them
- demonstrate a not-JSON-RPC API download endpoint
sipa commented at 12:42 AM on November 5, 2012: member

I like the idea of exposing certain data via HTTP instead of as RPC calls. Need to think about the format, though.
BitcoinPullTester commented at 5:09 AM on November 5, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/83dd3f31e230ce8b8cc50026454f5e9b9a2b36a6 for binaries and test log.
gavinandresen commented at 7:20 PM on November 5, 2012: contributor

OK on the first two commits. What is the use case for dumping crypted wallet keys?
jgarzik referenced this in commit 8146591a53 on Nov 9, 2012
RPC: support simple wallet crypted key dump via GET /wallet-ckeys.json 0a60c82ad6
jgarzik commented at 2:34 AM on November 16, 2012: contributor

Rebased. @gavinandresen wallet backup, that doesn't need to be encrypted yet again. @sipa has a fair point on format, though.
BitcoinPullTester commented at 6:52 PM on November 23, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0a60c82ad6f6acdd899825a5db65b2b1d2f7d841 for binaries and test log.
jgarzik commented at 11:09 PM on April 8, 2013: contributor

Closing. Not much interest, and wallet dump format still an open question.

Was originally at @kjj request.
jgarzik closed this on Apr 8, 2013
jgarzik referenced this in commit 9f4976afe2 on May 1, 2013
kyledrake referenced this in commit 0639ab5639 on Jul 25, 2013
laudney referenced this in commit 5f04022227 on Mar 19, 2014
laudney referenced this in commit d5307d390e on Mar 19, 2014
jgarzik deleted the branch on Aug 24, 2014
KolbyML referenced this in commit 3156f92be2 on Dec 5, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#2601 RPC: strictly require HTTP URI "/"#32089 Failure to run Fuzz tests when running with corpus