merged 2 windows:LIBS lines so they happen when they need to (#976) added -loleaut32 to fix VariantClear moved -lws2_32 and others to existing windows:LIBS line
VariantClear@4 + shutdown@8 patch #1984
pull grimd34th wants to merge 1 commits into bitcoin:master from grimd34th:patch-2 changing 1 files +1 −2-
grimd34th commented at 2:02 AM on November 5, 2012: contributor
-
90841fd5e0
VariantClear@4 + shutdown@8 patch
merged 2 windows:LIBS lines so they happen when they need to (#976) added -loleaut32 to fix VariantClear moved -lws2_32 and others to existing windows:LIBS line
-
Diapolo commented at 6:42 AM on November 5, 2012: none
@grimd34th I've been using a similar approach for months with my local Windows build, what wonders me is that the official build process seems to not need
-loleaut32, any idea for this?Otherwise I can confirm this change is needed to directly build on Windows!
Let's see what our pull-tester is making from this ;).
-
sipa commented at 11:26 PM on November 5, 2012: member
ACK. Does not break gitian build.
-
Diapolo commented at 12:31 PM on November 11, 2012: none
ACK then.
-
grimd34th commented at 4:02 PM on November 11, 2012: contributor
Diapolo, i had to add
-loleaut32as per https://github.com/Diapolo/bitcoin/commit/510f7fceb677ce1af3096f5c2b54f3832e5efee2 but i also shifted it around with the other deps - laanwj referenced this in commit 6caffb5358 on Nov 15, 2012
- laanwj merged this on Nov 15, 2012
- laanwj closed this on Nov 15, 2012
-
-
Diapolo commented at 9:45 PM on November 16, 2012: none
I really can't comment for < 0.6 as I never compiled any versions below that for myself, but I remember that some Boost version update made me use a similar project-file. Dunno remember more details, sorry.
- laudney referenced this in commit 1a9ca33f85 on Mar 19, 2014
- DrahtBot locked this on Sep 8, 2021
