Revert back to FILE_CHARS_BLACKLIST #19902

pull lviggiano wants to merge 1 commits into bitcoin:master from lviggiano:master changing 1 files +2 −2

lviggiano commented at 7:13 PM on September 6, 2020: none

Also fixes FILE_CHAR_BLACKLIST to FILE_CHARS_BLACKLIST.

It is important to keep bitcoin neutral and censorship resistant. The above commits were an attempt to push political activism into bitcoin code, and we shall not allow that to happen.

I am sorry to get back to this issue, but I think it is very important to reaffirm basic bitcoin values and push back on political attacks as serious security issues.

We already spent some time around this issue, please allow the community to reevaluate.

I retry the PR because of a typo in previous one. I won't try this again (sorry about that).

Revert back to FILE_CHARS_BLACKLIST

This reverts commits 637d8bce741213295bd9b9d1982cae663c701ba1 and 6fc641644f7193365cf2b40f5cf20374ec871943.
Also fixes FILE_CHAR_BLACKLIST to FILE_CHARS_BLACKLIST.

See: #19897, #19227

9de484c209

luke-jr commented at 7:15 PM on September 6, 2020: member

If you're going to fix it, fix it to be actually correct (it's not a blacklist). But I think everyone has had enough bikeshedding over this irrelevant name today. Please just leave it be.
lviggiano commented at 7:18 PM on September 6, 2020: none

@luke-jr yes, it should be fixed now, let me know if there is any other typo and I'll gladly take all the effort.
fiatjaf commented at 7:20 PM on September 6, 2020: none

I understand exactly what you're feeling and applaud the fact that you've created this PR, but I think at this point it's probably more reasonable with the patience of maintainers here to don't try to revert it anymore. It wouldn't be a long term solution to anything anyway.
jnewbery commented at 7:30 PM on September 6, 2020: member

Please stop spamming this repo. People have better things to spend their time on.
jnewbery closed this on Sep 6, 2020
jnewbery locked this on Sep 6, 2020

Contributors