PeerManager already keeps a reference to the chain params as a member variable. No need to pass it in once again as a function parameter.
refactor: Do not pass chain params to CheckForStaleTipAndEvictPeers twice #19914
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2009-netNo2ChainParams changing 3 files +15 −17-
MarcoFalke commented at 5:56 AM on September 8, 2020: member
-
Do not pass chain params to CheckForStaleTipAndEvictPeers twice fa7e407b50
- DrahtBot added the label P2P on Sep 8, 2020
- DrahtBot added the label Refactoring on Sep 8, 2020
-
naumenkogs commented at 6:52 AM on September 8, 2020: member
utACK fa7e407b504bc60c77341f02636ed9d6a4b53d79
-
promag commented at 7:07 AM on September 8, 2020: member
Code review fa7e407b504bc60c77341f02636ed9d6a4b53d79.
-
jnewbery commented at 7:56 AM on September 8, 2020: member
code review ACK fa7e407b504bc60c77341f02636ed9d6a4b53d79
-
epson121 commented at 1:33 PM on September 8, 2020: none
Code review ACK fa7e407b504bc60c77341f02636ed9d6a4b53d79
- MarcoFalke merged this on Sep 8, 2020
- MarcoFalke closed this on Sep 8, 2020
- MarcoFalke deleted the branch on Sep 8, 2020
- Fabcien referenced this in commit 5bc1e2c854 on Sep 28, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels