test: Run rpc_txoutproof.py even with wallet disabled #19922

1. 
   MarcoFalke commented at 8:43 am on September 9, 2020: member

   Run the consensus test even when the wallet was not compiled. Also:

   • Minor bugfix in MiniWallet
   • Two new test cases (one cherry-picked from #19847)
2. test: bugfix: Actually pick largest utxo fa65a11d0c
3. test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend

   Adds two new features to MiniWallet:
   
   * The fee rate is irrelevant sometimes, so just set an arbitrary default
   * The utxo to spend needs to be selected manually sometimes

   faba790bd4
4. fanquake added the label Tests on Sep 9, 2020
5. 
   jnewbery commented at 9:23 am on September 9, 2020: member

   Concept ACK. Moving all the remaining non-wallet tests to use MiniWallet could be a good first issue for newer contributors.
6. test: Run rpc_txoutproof.py even with wallet disabled fa56e866e8
7. test: Test empty array in gettxoutproof faf5eb45c4
8. test: gettxoutproof duplicate txid faf251d854
9. MarcoFalke force-pushed on Sep 9, 2020
10. 
    MarcoFalke commented at 10:17 am on September 9, 2020: member

    Force pushed to make travis python linter happy
11. 
    jnewbery commented at 11:52 am on September 9, 2020: member

    utACK faf251d854e3a670533ea3e9087e82c92f3ae533. Thanks Marco!
12. kristapsk approved
13. 
    kristapsk commented at 10:21 pm on September 10, 2020: contributor

    ACK faf251d854e3a670533ea3e9087e82c92f3ae533
14. laanwj merged this on Sep 11, 2020
15. laanwj closed this on Sep 11, 2020

    ---

16. sidhujag referenced this in commit 316baa657c on Sep 11, 2020
17. MarcoFalke deleted the branch on Oct 2, 2020
18. 
    stackman27 commented at 7:04 am on January 6, 2021: contributor

    @MarcoFalke I realize that this is a merged PR, but I just had some hanging issues/comments regarding implementing create_lots_of_big_transactions while restructuringmempool_limit.py. My biggest concern is that wouldn’t we need to change send_self_transfer to accommodate extra appends in the transaction outputs to make it large? or is there something i’m missing out? Any help is really appreciated
19. 
    MarcoFalke commented at 7:14 am on January 6, 2021: member

    send_self_transfer only handles a single-in-single-out tx. If multi-in-multi-out txs are needed, it could make sense to add a new method for that.
20. 
    stackman27 commented at 7:21 am on January 6, 2021: contributor

    send_self_transfer only handles a single-in-single-out tx. If multi-in-multi-out txs are needed, it could make sense to add a new method for that.

    Alright, I will open a PR soon with respected changes. Thank you :)

21. Fabcien referenced this in commit fcff4d7d97 on Oct 11, 2021
22. Fabcien referenced this in commit b2c8b9cca7 on Oct 11, 2021
23. Fabcien referenced this in commit eefddc5047 on Oct 11, 2021
24. PiRK referenced this in commit 93de371112 on Aug 16, 2022
25. PiRK referenced this in commit d3e84aa803 on Aug 16, 2022
26. PiRK referenced this in commit 9bceed73cc on Aug 16, 2022
27. DrahtBot locked this on Aug 16, 2022

Contributors
MarcoFalke jnewbery kristapsk stackman27

Labels
Tests