I’m opening this PR to give a convenient way to see the history #19953 goes through, as review comments get addressed.
The intent is to only add commits here, and use merge commit when the real PR undergoes a rebase.
It is marked draft as this branch isn’t expected to be merged.
PREV="$(git rev-parse HEAD)"; git log --oneline upstream/master..HEAD | while read C L; do if [ "d${L:0:14}" == "d--- [TAPROOT] " ]; then if [ "d$PREV" != "" ]; then git diff --shortstat $C..$PREV | (read _ _ _ ADD _ DEL _; echo "### ${L:14:-4} (https://github.com/sipa/bitcoin/compare/$C...$PREV) [+$ADD -$DEL]:"); echo; fi; PREV=$C; PREVL=$L; else echo -n " * $C **${L}**: "; git show "$C" --format="%b" -s | awk '/^$/{exit} 1' | tr $'\n' ' '; echo; fi; done | tac
Initial version (2020-09-20) [+2730 -118]
- 0daa3708e2 scripted-diff: put ECDSA in name of signature functions: In preparation for adding Schnorr versions of
CheckSig,VerifySignature, andComputeEntry, give them an ECDSA specific name. - 135f12ad38 refactor: rename scriptPubKey in VerifyWitnessProgram to exec_script: The old name is confusing, as it doesn’t store a scriptPubKey, but the actually executed script.
- f4d16cf644 refactor: keep spent outputs in PrecomputedTransactionData: A BIP-341 signature message may commit to the scriptPubKeys and amounts of all spent outputs (including other ones than the input being signed for spends), so keep them available to signature hashing code.
- 60ce12334f Add TaggedHash function (BIP 340): This adds the TaggedHash function as defined by BIP340 to the hash module, which is used in BIP340 and BIP341 to produce domain-separated hashes.
- 34da219826 Implement Taproot signature hashing (BIP 341): This implements the new sighashing scheme from BIP341, with all relevant whole-transaction values precomputed once and cached.
- 52ddb42100 Support for Schnorr signatures and integration in SignatureCheckers (BIP 340): This enables the schnorrsig module in libsecp256k1, adds the relevant types and functions to src/pubkey, as well as in higher-level
SignatureCheckerclasses. The (verification side of the) BIP340 test vectors is also added. - 828aed0abd Implement Taproot validation (BIP 341): This includes key path spending and script path spending, but not the Tapscript execution implementation (leaf 0xc0 remains unemcumbered in this commit).
- a39a7ec822 Use ScriptExecutionData to pass through annex hash: Instead of recomputing the annex hash every time a signature is verified, compute it once and cache it in a new ScriptExecutionData structure.
- ebce9826f9 Implement Tapscript script validation rules (BIP 342): This adds a new
SigVersion::TAPSCRIPT, makes the necessary interpreter changes to make it implement BIP342, and uses them for leaf version 0xc0 in Taproot script path spends. - 812c85615c Make Taproot spends standard + policy limits: This adds a
TxoutType::WITNESS_V1_TAPROOTfor P2TR outputs, and permits spending them in standardness rules. No correspondingCTxDestinationis added for it, as that isn’t needed until we want wallet integration. The taproot validation flags are also enabled for mempool transactions, and standardness rules are added (stack item size limit, no annexes). - 5ee49fd3b8 Activate Taproot/Tapscript on regtest (BIP 341, BIP 342): Define a versionbits-based activation for the new consensus rules on regtest. No activation or activation mechanism is defined for testnet or mainnet.
- 697d461682 [TESTS] Add BIP340 Schnorr signature support to test framework: Add a pure Python implementation of BIP340 signing and verification, tested against the BIP’s test vectors.
- fd6e288349 [TESTS] Functional tests for Schnorr/Taproot/Tapscript: A large functional test is added that automatically generates random transactions which exercise various aspects of the new rules, and verifies they are accepted into the mempool (when appropriate), and correctly accepted/rejected in (Python-constructed) blocks.
- 64030b1152 [TESTS] Add minimized test vector as unit test: This adds a relatively small set of test cases for the BIP341/BIP342 script validation rules as a unit test. The tests were generated by modifying the feature_taproot.py randomized tester to dump the constructed transactions and witnesses used, and using the fuzzing framework to minimize it.
Updates 2020-09-22 (https://github.com/sipa/bitcoin/compare/33b6a13c86...076dfd97a37678fb7fe818f94e37ede6b5d6048d) [+38 -38]:
- 4f5272cf5c Document length assumption in XOnlyPubKey::VerifySchnorr correctly:
- 672b1af9c2 Make IsOpSuccess match BIP text more closely:
- c22d75b702 Use OP_SUCCESSx instead of SUCCESSx in error message:
- 550edc05e5 Simplify/clarify tweak_add_{priv,pub}_key in tests:
- 076dfd97a3 Python assert does not need parens:
Update: test vectors in qa-assets (https://github.com/sipa/bitcoin/compare/388928824e...9dfcd363a9) [+98 -43]:
- 00d8575ffc Always clone qa-assets repo in CI, but shallowly:
- 35fc47be36 Improve script unit test and use qa-assets JSON:
Updates 2020/09/23 (https://github.com/sipa/bitcoin/compare/9dfcd363a9...7d694f8f7606de64d864ed87d8fe1d2037a46ec6) [+6 -110]:
- cdc57baa72 Script interpreter nits:
- 2612d16422 Document implicit CLEANSTACK/MINIMALIF in witv0/tapscript execution:
- 7d694f8f76 Remove script_taproot_tests (moved to qa-assets):
Updates 2020/09/24 (https://github.com/sipa/bitcoin/compare/b5d2f3bab8...1ec9ce2ed7a8c95228f0c3ee473531eb8ab6119d) [+28 -13]:
- 4181a0c1d6 Exit bip143/341 checking loop early:
- 4e6c2005f4 Make SignatureHashCache take cache reference instead of pointer:
- 29bf92a5b0 Use separate script error for tapscript MINIMALIF:
- 1ec9ce2ed7 Add a test for consensus CLEANSTACK in tapscript:
Updates 2020/10/01 (https://github.com/sipa/bitcoin/compare/8e8b45868b...99c50a691a) [+294 -27]:
- ba4ac3e832 Improve some code comments:
- c634f7ecdb Compute witnesses only once for each input in feature_taproot.py: Instead of re-evaluating the entire signing logic for every input, for every attempt, compute them once and reuse them.
- 9e963a0ffb Run legacy tests with both compressed and uncompressed keys:
- 687c91ae54 Use a separate prefix for legacy tests that need taproot validation tests:
- 6d23fd6a09 Add support for dumping generated test cases:
- 7d5fd3c1d9 Add fuzz ’test’ to minimize script_assets_test.json:
Merge with master 2020/10/02 (https://github.com/sipa/bitcoin/compare/99c50a691a...6cf077da50e9a2a3fdeaac9e96be5312d3cb8d76) [+21666 -4524]:
- 31031361c3 Merge remote-tracking branch ‘upstream/master’ into taproot-history:
- 6cf077da50 Fix expected error message in feature_taproot.py:
Updates 2020/10/06 (https://github.com/sipa/bitcoin/compare/490b974364...10b9a4836a3bf57ce59d741ae5dfab5cdf0186e6) [+11 -7]:
- 4ade5781b4 Avoid a ScriptExecutionData copy in EvalScript:
- 10b9a4836a Remove inadvertantly added newlines:
Updates 2020/10/07 (https://github.com/sipa/bitcoin/compare/68ebf4a2de...836232441c41788c720a7858c0521c9ea405c5b7) [+21 -17]:
- 3265f14e39 Variable naming/typing/calling improvements:
- c1710042e5 Use more constexpr:
- 2ea6a0a3c2 Consistent comment style:
- 836232441c Add comments referencing the BIPs:
Updates 2020/10/08 (https://github.com/sipa/bitcoin/compare/5a7897645a...67750a3e1ed1696c09a998d7f5758394d896f99d) [+85 -72]:
- fb6bc8a099 Decide key_version based on sigversion instead of passing through:
- 67750a3e1e Report more detailed signature validation errors:
Updates 2020/10/11 (https://github.com/sipa/bitcoin/compare/ce24bbba4b...7029ff57025a5e3fcc755b5da288ff70e2f2d2d7) [+13 -15]:
- 2127387e30 Add extra assertion on spent_outputs size:
- 11c05b47d7 Rename fSuccess -> success in comments:
- 1a464c6c4c Small fixes to feature_taproot.py:
- 7029ff5702 Some style fixes:
Updates 2020/10/12 (https://github.com/sipa/bitcoin/compare/36f4fa5ef9...4e2ac63b16a0764f903c639712cee86d8eacc96c) [+5 -5]:
- 34a93d775a Really rename fuccess -> success in comments:
- 4e2ac63b16 Pass tapleaf_hash by reference to VerifyTaprootCommitment:
