RPC: remove duplicate line in getblock help #20064

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:getblock_help changing 1 files +0 −1
  1. fjahr commented at 10:25 pm on October 2, 2020: member

    Line simply seems duplicated in error.

    Testing instructions: Run src/bitcoin-cli help getblock on master branch to reproduce. Then build this PR and compare its results.

  2. fjahr commented at 10:27 pm on October 2, 2020: member
    Can someone please add the “Good first review” label? Thanks :)
  3. sipa added the label Good First Review on Oct 2, 2020
  4. RPC: remove duplicate line in getblock help 1885ad3546
  5. fjahr force-pushed on Oct 2, 2020
  6. fjahr renamed this:
    RPC: remove dublicate line in getblock help
    RPC: remove duplicate line in getblock help
    on Oct 2, 2020
  7. luke-jr approved
  8. luke-jr commented at 11:03 pm on October 2, 2020: member
    utACK
  9. kristapsk approved
  10. kristapsk commented at 11:54 pm on October 2, 2020: contributor
    ACK 1885ad35467f201f2a210057797aae8a450e7cdf
  11. benthecarman approved
  12. yahiheb approved
  13. yahiheb commented at 6:13 am on October 3, 2020: contributor
    utACK
  14. dhruv commented at 6:29 am on October 3, 2020: member

    tACK 1885ad3


    On master:54fc96ffa70ad3a53d32709101b7a2ce064d822e

     0Result (for verbosity = 2):
     1{             (json object)
     2  ...,        Same output as verbosity = 1
     3  "tx" : [    (json array)
     4    {         (json object)
     5      ...     The transactions in the format of the getrawtransaction RPC. Different from verbosity = 1 "tx" result
     6    },
     7    ...
     8  ],
     9  ...         Same output as verbosity = 1
    10}
    

    On pr/20064:1885ad35467f201f2a210057797aae8a450e7cdf

    0Result (for verbosity = 2):
    1{             (json object)
    2  ...,        Same output as verbosity = 1
    3  "tx" : [    (json array)
    4    {         (json object)
    5      ...     The transactions in the format of the getrawtransaction RPC. Different from verbosity = 1 "tx" result
    6    },
    7    ...
    8  ]
    9}
    

  15. Emzy commented at 11:16 am on October 3, 2020: contributor
    tACK 1885ad35467f201f2a210057797aae8a450e7cdf Works as intended.
  16. fanquake merged this on Oct 5, 2020
  17. fanquake closed this on Oct 5, 2020

  18. sidhujag referenced this in commit 6307003070 on Oct 6, 2020
  19. Fabcien referenced this in commit bdee6e23b3 on Nov 3, 2021
  20. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me