RPC: remove duplicate line in getblock help #20064

pull fjahr wants to merge 1 commits into bitcoin:master from fjahr:getblock_help changing 1 files +0 −1

fjahr commented at 10:25 PM on October 2, 2020: member

Line simply seems duplicated in error.

Testing instructions: Run src/bitcoin-cli help getblock on master branch to reproduce. Then build this PR and compare its results.
fjahr commented at 10:27 PM on October 2, 2020: member

Can someone please add the "Good first review" label? Thanks :)
sipa added the label Good First Review on Oct 2, 2020
RPC: remove duplicate line in getblock help 1885ad3546
fjahr force-pushed on Oct 2, 2020
fjahr renamed this:
~~RPC: remove dublicate line in getblock help~~
RPC: remove duplicate line in getblock help
on Oct 2, 2020
luke-jr approved
luke-jr commented at 11:03 PM on October 2, 2020: member

utACK
kristapsk approved
kristapsk commented at 11:54 PM on October 2, 2020: contributor

ACK 1885ad35467f201f2a210057797aae8a450e7cdf
benthecarman approved
yahiheb approved
yahiheb commented at 6:13 AM on October 3, 2020: contributor

utACK

dhruv commented at 6:29 AM on October 3, 2020: member

tACK 1885ad3

On master:54fc96ffa70ad3a53d32709101b7a2ce064d822e

Result (for verbosity = 2):
{             (json object)
  ...,        Same output as verbosity = 1
  "tx" : [    (json array)
    {         (json object)
      ...     The transactions in the format of the getrawtransaction RPC. Different from verbosity = 1 "tx" result
    },
    ...
  ],
  ...         Same output as verbosity = 1
}

On pr/20064:1885ad35467f201f2a210057797aae8a450e7cdf

Result (for verbosity = 2):
{             (json object)
  ...,        Same output as verbosity = 1
  "tx" : [    (json array)
    {         (json object)
      ...     The transactions in the format of the getrawtransaction RPC. Different from verbosity = 1 "tx" result
    },
    ...
  ]
}

Emzy commented at 11:16 AM on October 3, 2020: contributor

tACK 1885ad35467f201f2a210057797aae8a450e7cdf Works as intended.
fanquake merged this on Oct 5, 2020
fanquake closed this on Oct 5, 2020
sidhujag referenced this in commit 6307003070 on Oct 6, 2020
Fabcien referenced this in commit bdee6e23b3 on Nov 3, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels