(serious) bug with wrong system clock #2007

1. 
   Diapolo commented at 3:04 pm on November 13, 2012: none

   I set my computers date to 2012-07-13 and tried to start the client (current master) and during startup it simply crashes. This is from the debug.log:

   There should be a check and warning like the one in util.cpp - AddTimeData(), but this needs to be done from some core dev.

2. 
   Diapolo commented at 3:15 pm on November 14, 2012: none

   Did any other dev try this? Or am I the only one that can re-create that crash situation?
3. 
   Diapolo commented at 2:52 pm on November 20, 2012: none

   @sipa Did you check this out? Does it happen also on Linux or with bitcoind?
4. 
   Azulan commented at 7:57 am on November 26, 2012: none

   Would it be possible to make an NTP request to a one of a list of well known time servers to check for this kind of problem?
5. 
   laanwj commented at 11:38 am on November 26, 2012: member

   This problem would be solved with a friendlier error message. Bailing out as early as possible is all we can do when the user’s clock is detected to be wrong by this much.

   (p2p nodes already send their time so ntp is not needed, and relying on well known servers would be a big nono for a distributed protocol)

6. 
   Diapolo commented at 3:16 pm on November 26, 2012: none

   @laanwj I would prefer an error message before the client simply crashes, before we talk about how friedly that message should be :-D. Does a wrong time cause a crash on Linux, too with current master?
7. 
   Azulan commented at 0:00 am on November 27, 2012: none

   I would suggest it as a client feature, not a part of the protocol.

   But you are right, the protocol does seem to provide for time services already. I apologize for the superfluous suggestion.

8. 
   Diapolo commented at 1:08 am on January 26, 2013: none

   @sipa Any comment for this one?
9. laanwj closed this on Aug 5, 2015

   ---

10. HashUnlimited referenced this in commit 8d01ab9dda on Mar 21, 2018
11. KolbyML referenced this in commit a0d5b62e5b on Dec 5, 2020
12. MarcoFalke locked this on Sep 8, 2021

Contributors
Diapolo Azulan laanwj

Labels
Bug