Wallet: Reenable -fallbackfee by default for regtest and signet (and maybe testnet too)? #20087

issue michaelfolkson opened this issue on October 5, 2020
  1. michaelfolkson commented at 4:29 PM on October 5, 2020: contributor

    This PR merged in October 2019 disabled -fallbackfee by default across all chains (mainnet, testnet, regtest).

    The only motivation for doing this for regtest (and maybe testnet too) that I can see is:

    Now it is 0 by default for all chains, thus there's no need to call Params(). (comment)

    However, this does mean that if you don't set a fee or enable -fallbackfee you get this error.

    error code: -4
    error message:
    Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.
    

    Any thoughts on reenabling -fallbackfee by default for regtest, signet (and maybe testnet too)? I think it makes sense to continue to have it disabled by default for real money on mainnet.

    If I'm missing context please direct me to it and I'll close this.

    Bitcoin StackExchange post: https://bitcoin.stackexchange.com/questions/97174/when-using-bitcoin-cli-i-get-an-error-regarding-fallback-fees-when-trying-to-sen

  2. michaelfolkson added the label Feature on Oct 5, 2020
  3. maflcko added the label Tests on Oct 5, 2020
  4. maflcko added the label Brainstorming on Oct 5, 2020
  5. maflcko commented at 4:52 PM on October 5, 2020: member

    No strong opinion, but I have a slight preference to keep it the way it is. If documentation is missing, then it should be improved. The error message could probably be updated on how to set a feerate over RPC, not just the startup setting, which would require a restart of the server.

  6. maflcko added the label RPC/REST/ZMQ on Oct 5, 2020
  7. maflcko added the label Wallet on Oct 5, 2020
  8. maflcko removed the label RPC/REST/ZMQ on Oct 5, 2020
  9. michaelfolkson commented at 5:14 PM on October 5, 2020: contributor

    So an extended error message, something like:

    Fee estimation failed and -fallbackfee is disabled. Enable -fallbackfee (requires restart), wait a few blocks or manually set a fee as an additional argument to your bitcoin-cli command e.g. 1 sat/B

    You don't want too long error messages right?

  10. maflcko commented at 6:03 PM on October 5, 2020: member

    You don't want too long error messages right?

    Right. Maybe it is time to explain Bitcoin Core fee estimation/fee settings to users in one document and refer to that in the error message?

  11. michaelfolkson commented at 3:28 PM on October 10, 2020: contributor

    Yeah I think the above is the best approach longer term. I'll close this for now. Thanks

  12. michaelfolkson closed this on Oct 10, 2020

  13. maflcko commented at 6:02 PM on October 10, 2020: member

    Heh, this is still something that should be addressed. ;)

  14. maflcko reopened this on Oct 10, 2020

  15. michaelfolkson commented at 9:12 PM on October 11, 2020: contributor

    Ok I'm happy for this to be a good first issue or to do it myself.

    For now here are some resources that will be useful.

    Presumably you mean something like this PSBT doc but for fee estimation/fee settings. And stored in the doc directory.

  16. maflcko commented at 8:59 AM on March 10, 2023: member

    The issue didn't seem to attract much attention in the past. Also, the issue seems not important enough right now to keep it sitting around idle in the list of open issues.

    Closing due to lack of interest and direction. Pull requests with improvements are always welcome.

  17. maflcko closed this on Mar 10, 2023

  18. bitcoin locked this on Mar 9, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me