Prevent RPC ‘move’ from deadlocking #2009

1. 
   sipa commented at 11:33 pm on November 13, 2012: member

   It seemed to create two CWalletDB objects that both grab the database lock.

   (note: based on v0.7.1)

2. Prevent RPC 'move' from deadlocking

   It seemed to create two CWalletDB objects that both grab the
   database lock.

   4291e8feab
3. 
   luke-jr commented at 11:37 pm on November 13, 2012: member

   ACK
4. 
   laanwj commented at 6:21 am on November 14, 2012: member

   I’m probably overlooking something, but if the lock is grabbed twice in the same thread, how can that cause a deadlock with recursive mutexes?
5. 
   sipa commented at 8:50 am on November 14, 2012: member

   It would seem the BDB locks are not recursive.
6. 
   laanwj commented at 9:13 am on November 14, 2012: member

   Right,it wasn’t clear to me that this concerns the bdb locks, thanks. ACK ofc.
7. 
   sipa commented at 7:36 pm on November 14, 2012: member

   @gavinandresen Do you think this warrants a 0.7.2?
8. 
   gavinandresen commented at 8:12 pm on November 14, 2012: contributor

   Yes, I think this is serious enough to warrant a 0.7.2.
9. 
   luke-jr commented at 9:22 pm on November 14, 2012: member

   I have 0.7.x ready-to-tag as soon as this gets pulled in to master.

   Other fixes included:

   • faff50d Fixes a race condition in CreateNewBlock and a future null deref on testnet.
   • 4fbad91 Fix out-of-bounds read noticed by Ricardo Correia
   • bd2e140 CAddrMan: verify pchMessageStart file marker, before reading address data
   • 22bb049 Fix a use-after-free problem in initialization (#1920)
   • c4d884e No need for test fixture now that multisig is enabled on main network.
   • 128eefa Qt: small header changes / fixes
   • 6b3783a fix some double-spaces in strings
   • 83a3fb8 ensure AskPassphraseDialog::eventFilter forwards events
   • 0f8a647 don’t use memset() in privacy/security relevant code parts
   • 39ad0aa Fixed 100% CPU utilization problem on FreeBSD 9
10. 
    Diapolo commented at 1:10 pm on November 16, 2012: none

    @luke-jr I would not include https://github.com/bitcoin/bitcoin/commit/6b3783a as this needs the bitcoinstrings.cpp update (#1999) and a new master file on Transifex, which is what I’m waiting for to start translating the german stuff, to have the changes in for all languages. It’s clearly for 0.8 (and already merged in master) and non-critical + needs time to mature.
11. 
    gavinandresen commented at 1:33 pm on November 16, 2012: contributor

    NACK on these, as I don’t think they pass the risk/benefit test:

    • 128eefa https://github.com/bitcoin/bitcoin/commit/128eefa Qt: small header changes / fixes
    • 6b3783a https://github.com/bitcoin/bitcoin/commit/6b3783a fix some double-spaces in strings
    • 0f8a647 https://github.com/bitcoin/bitcoin/commit/0f8a647 don’t use memset() in privacy/security relevant code parts

    Gavin Andresen

12. 
    Diapolo commented at 2:02 pm on November 16, 2012: none

    @gavinandresen I disagree here, as I think https://github.com/bitcoin/bitcoin/commit/0f8a647 is quite an important fix / change.
13. gavinandresen referenced this in commit e45d39f9ee on Nov 16, 2012
14. gavinandresen merged this on Nov 16, 2012
15. gavinandresen closed this on Nov 16, 2012

    ---

16. laudney referenced this in commit 0b8aba7017 on Mar 19, 2014
17. HashUnlimited referenced this in commit fb5076888b on Mar 21, 2018
18. KolbyML referenced this in commit 3ec4f66a8b on Dec 5, 2020
19. DrahtBot locked this on Sep 8, 2021

Contributors
sipa luke-jr laanwj gavinandresen Diapolo