Seems confusing to disable a test-only RPC for some test chains.
This pull also contains an unrelated test speedup (related to mocktime, though).
test: Enable mocktime RPC for all test chains #20103
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2010-testMockAllChains changing 4 files +19 −16-
MarcoFalke commented at 10:13 AM on October 8, 2020: member
-
test: Speed up wallet_resendwallettransactions test with mockscheduler RPC fa98175697
-
test: Enable mocktime RPC for all test chains fac37bca55
- fanquake added the label Tests on Oct 8, 2020
-
ajtowns commented at 10:24 PM on October 8, 2020: member
I don't think mocktime makes sense for any chain that's shared amongst untrusted peers; ie setting mocktime on testnet and the default signet wouldn't make sense. If you use -regtest when you've got trusted peers (it's quicker than a custom signet) and a custom signet when you have untrusted peers (since -regtest is trivial to abuse), then the "mocktime only on -regtest" is a perfect match.
-
MarcoFalke commented at 7:14 AM on October 9, 2020: member
Ok, closing
- MarcoFalke closed this on Oct 9, 2020
- MarcoFalke deleted the branch on Oct 9, 2020
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels