[net] Remove CombinerAll #20105

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:2020-10-remove-combiner-all changing 2 files +0 −32

jnewbery commented at 11:19 AM on October 8, 2020: member

This was introduced in 9519a9a4 for use with boost signals. Boost signals have not been used in net since 8ad663c1, so this code is unused.
jnewbery force-pushed on Oct 8, 2020

in src/test/validation_tests.cpp:128 in 5ee0400067 outdated

 119 | @@ -120,20 +120,4 @@ BOOST_AUTO_TEST_CASE(signet_parse_tests)
 120 |      BOOST_CHECK(!CheckSignetBlockSolution(block, signet_params->GetConsensus()));
 121 |  }
 122 |  
 123 | -static bool ReturnFalse() { return false; }
 124 | -static bool ReturnTrue() { return true; }
 125 | -
 126 | -BOOST_AUTO_TEST_CASE(test_combiner_all)
 127 | -{
 128 | -    boost::signals2::signal<bool (), CombinerAll> Test;

MarcoFalke commented at 11:26 AM on October 8, 2020:

Is the #include <boost/signals2/signal.hpp> still needed, now that this is removed?

jnewbery commented at 11:29 AM on October 8, 2020:

indeed not. Good spot. Now removed

MarcoFalke added the label Refactoring on Oct 8, 2020

[net] Remove CombinerAll

This was introduced in 9519a9a4 for use with boost signals. Boost signals
have not been used in net since 8ad663c1, so this code is unused

1afcd41a90

jnewbery force-pushed on Oct 8, 2020
MarcoFalke commented at 11:41 AM on October 8, 2020: member

review ACK 1afcd41a906e6417925e80578c0d850d269dc008
DrahtBot commented at 12:57 PM on October 8, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #19806 (validation: UTXO snapshot activation by jamesob)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj commented at 6:09 PM on October 8, 2020: member

A pure code removal that's nice

code review ACK 1afcd41a906e6417925e80578c0d850d269dc008
laanwj merged this on Oct 8, 2020
laanwj closed this on Oct 8, 2020
sidhujag referenced this in commit 95763c1b79 on Oct 8, 2020
jnewbery deleted the branch on Oct 8, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

[net] Remove CombinerAll #20105

Conflicts