tests: don't export in6addr

vasild commented at 8:28 AM on October 12, 2020: member

Don't export in6addr_loopback because that upsets contrib/devtools/symbol-check.py

Fixes #20127

tests: don't export in6addr_loopback

Don't export `in6addr_loopback` because that upsets
`contrib/devtools/symbol-check.py`

Fixes https://github.com/bitcoin/bitcoin/issues/20127

8e4d62280e

vasild commented at 8:32 AM on October 12, 2020: member

Either the patch in this PR or the following should fix the problem (as mentioned in #20127 (comment)):

diff --git i/contrib/devtools/symbol-check.py w/contrib/devtools/symbol-check.py
index 6949cb7ce..5178ac0d4 100755
--- i/contrib/devtools/symbol-check.py
+++ w/contrib/devtools/symbol-check.py
@@ -45,13 +45,13 @@ MAX_VERSIONS = {
 # See here for a description of _IO_stdin_used:
 # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=634261#109
 
 # Ignore symbols that are exported as part of every executable
 IGNORE_EXPORTS = {
 '_edata', '_end', '__end__', '_init', '__bss_start', '__bss_start__', '_bss_end__', '__bss_end__', '_fini', '_IO_stdin_used', 'stdin', 'stdout', 'stderr',
-'environ', '_environ', '__environ',
+'environ', '_environ', '__environ', 'in6addr_loopback',
 }
 READELF_CMD = os.getenv('READELF', '/usr/bin/readelf')
 CPPFILT_CMD = os.getenv('CPPFILT', '/usr/bin/c++filt')
 OBJDUMP_CMD = os.getenv('OBJDUMP', '/usr/bin/objdump')
 OTOOL_CMD = os.getenv('OTOOL', '/usr/bin/otool')

MarcoFalke added the label Needs gitian build on Oct 12, 2020

MarcoFalke added the label Needs Guix build on Oct 12, 2020

laanwj commented at 4:08 PM on October 12, 2020: member

Concept ACK, but I do wonder, why do we run the symbol check on the unit tests?

Edit: oh I guess because they are shipped in the binary release. Never mind.

MarcoFalke assigned fanquake on Oct 12, 2020

sipa commented at 1:09 AM on October 13, 2020: member

utACK 8e4d62280e3d3fa729e71d557ba457a3e08349f8

hebasto approved

hebasto commented at 6:13 AM on October 13, 2020: member

ACK 8e4d62280e3d3fa729e71d557ba457a3e08349f8

https://www.man7.org/linux/man-pages/man7/ipv6.7.html:

   The IPv6 loopback address (::1) is available in the global
   in6addr_loopback variable.  For initializations,
   IN6ADDR_LOOPBACK_INIT should be used.

MarcoFalke added this to the milestone 0.21.0 on Oct 13, 2020

MarcoFalke added the label Tests on Oct 13, 2020

DrahtBot commented at 8:26 AM on October 13, 2020: member

Guix builds

File	commit af22322dab1a2277483b2512723491a5fad1a606<br>(master)	commit e82cef03929fe1c2765c15821afc45fcb0bb4415<br>(master and this pull)
*.tar.gz	`49fc39677cb83da9...`	`d7e014362b8312f9...`
guix_build.log	`6d43f784f30e747e...`	`c9397f32d58f316b...`
*-aarch64-linux-gnu-debug.tar.gz		`bfdd6993eeca8963...`
*-aarch64-linux-gnu.tar.gz		`a7576f72780a2064...`
*-arm-linux-gnueabihf-debug.tar.gz		`9dfc741bea1728b1...`
*-arm-linux-gnueabihf.tar.gz		`05adddab86580262...`
*-riscv64-linux-gnu-debug.tar.gz		`8c52e23b19642e5b...`
*-riscv64-linux-gnu.tar.gz		`7995fd095c2b57e3...`
*-win-unsigned.tar.gz		`6b381a43bea0cd4d...`
*-win64-debug.zip		`9e4a0e6d95b56a13...`
*-win64-setup-unsigned.exe		`d825f54d38a61551...`
*-win64.zip		`4867268f0470e3e5...`
*-x86_64-linux-gnu-debug.tar.gz		`0e82db708fa671ae...`
*-x86_64-linux-gnu.tar.gz		`ff5ba842d9d9a811...`
guix_build.log.diff		`f34a36588b25dbc2...`

DrahtBot removed the label Needs Guix build on Oct 13, 2020

DrahtBot commented at 10:45 PM on October 13, 2020: member

Gitian builds

File	commit f79a4a895279ba4efa43494270633f94f7d18342<br>(master)	commit 63e44447bb1fbd3ac5c458e6e41c72610d02a275<br>(master and this pull)
bitcoin-core-osx-0.21-res.yml	`3eda2a7abad38ea5...`	`52b8342b13f2c1f9...`
bitcoin-core-win-0.21-res.yml	`9e60f138c574df1b...`	`0a1f2598a4409070...`
*-osx-unsigned.dmg	`0d00d9335ca475a6...`	`f4dd7f8bd0d7fea2...`
*-osx64.tar.gz	`e19b41b6fcdeaacf...`	`0de5ffb4d28e5462...`
*-win64-debug.zip	`2cf56803736361f5...`	`0a7ffdbd8daa9728...`
*-win64-setup-unsigned.exe	`03956c76f192e191...`	`23198680270fbaaa...`
*-win64.zip	`eefd31964e1a8826...`	`7b3b8a00518091e2...`
*.tar.gz	`edbc26df00891dbb...`	`851a782955e9282b...`
linux-build.log	`d0867141a78ed8f0...`	`f1c8b400e9fbf769...`
osx-build.log	`0c4e440f2871528d...`	`bc6238c39ebe4666...`
win-build.log	`b0a0df35e46cca96...`	`3317f30918c5c0c7...`
*-aarch64-linux-gnu-debug.tar.gz		`1f1432ebe7d3c4c8...`
*-aarch64-linux-gnu.tar.gz		`30bfbe93d50c5a91...`
*-arm-linux-gnueabihf-debug.tar.gz		`4916f9c1c9d3964f...`
*-arm-linux-gnueabihf.tar.gz		`c4b24e7aba77b53f...`
*-riscv64-linux-gnu-debug.tar.gz		`223eb1550a5bb1e7...`
*-riscv64-linux-gnu.tar.gz		`1acac0e837649b01...`
*-x86_64-linux-gnu-debug.tar.gz		`3b9776164eba425c...`
*-x86_64-linux-gnu.tar.gz		`5b4dd9fca4f63f01...`
bitcoin-core-linux-0.21-res.yml		`dbba7bd8a5a61928...`
bitcoin-core-osx-0.21-res.yml.diff		`b7eb2f4715bec52f...`
bitcoin-core-win-0.21-res.yml.diff		`fbfdbe663077949e...`
linux-build.log.diff		`30d866a0f9487ad9...`
osx-build.log.diff		`b27f9c41ffbe79ff...`
win-build.log.diff		`e2bdbb7238fa1acc...`

DrahtBot removed the label Needs gitian build on Oct 13, 2020

MarcoFalke merged this on Oct 14, 2020

MarcoFalke closed this on Oct 14, 2020

vasild deleted the branch on Oct 14, 2020

Fabcien referenced this in commit e9b2955f86 on Feb 11, 2021

UdjinM6 referenced this in commit c54237617d on Aug 30, 2021

UdjinM6 referenced this in commit b88f7ed20f on Sep 7, 2021

DrahtBot locked this on Feb 15, 2022

tests: don't export in6addr_loopback #20129

Guix builds

Gitian builds