wallet: do not import a descriptor with hardened derivations into a watch-only wallet #20153

1. 
   S3RK commented at 11:14 am on October 15, 2020: member

   Currently importdescriptor command will successfully import a descriptor with hardened derivations into a watch-only wallet while silently failing to expand the descriptor to fill the cache. This leads to a broken wallet state and failure to load such wallet due to missing cache on subsequent restart.
2. wallet: fix importdescriptor silent fail 538be4219a
3. fanquake added the label Wallet on Oct 15, 2020
4. fanquake requested review from achow101 on Oct 15, 2020
5. 
   DrahtBot commented at 4:27 pm on October 15, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19651 (wallet: importdescriptors update existing by S3RK)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. achow101 approved
7. 
   achow101 commented at 4:47 pm on October 21, 2020: member

   ACK 538be4219ae7e65862e4aff540af88c9421e6061
8. 
   achow101 commented at 4:47 pm on October 21, 2020: member

   This should probably be added to the 0.21 milestone.
9. MarcoFalke added this to the milestone 0.21.0 on Oct 21, 2020
10. 
    luke-jr commented at 6:59 pm on October 24, 2020: member

    Concept ACK. Looked over the code too, and it looks fine to me, but I didn’t dig in deep enough to be comfortable with a full utACK.
11. 
    meshcollider commented at 11:01 pm on November 1, 2020: contributor

    utACK 538be4219ae7e65862e4aff540af88c9421e6061
12. 
    laanwj commented at 7:15 pm on November 9, 2020: member

    Code review ACK 538be4219ae7e65862e4aff540af88c9421e6061
13. laanwj merged this on Nov 9, 2020
14. laanwj closed this on Nov 9, 2020

    ---

15. sidhujag referenced this in commit 3619f449e2 on Nov 10, 2020
16. Fabcien referenced this in commit 1975ab79f0 on Dec 22, 2021
17. DrahtBot locked this on Feb 15, 2022

Contributors
S3RK DrahtBot achow101 luke-jr meshcollider laanwj

Labels
Wallet

Milestone
0.21.0