test: Fix intermittent issue in p2p_feefilter #20176

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2010-testFixIntIssue changing 1 files +2 −1

MarcoFalke commented at 3:54 PM on October 17, 2020: member

Fixes:

Traceback (most recent call last):
  File "test/functional/test_framework/test_framework.py", line 126, in main
    self.run_test()
  File "test/functional/p2p_feefilter.py", line 63, in run_test
    self.test_feefilter()
  File "test/functional/p2p_feefilter.py", line 117, in test_feefilter
    txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00020000'), from_node=node1)['wtxid'] for _ in range(3)]
  File "test/functional/p2p_feefilter.py", line 117, in <listcomp>
    txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00020000'), from_node=node1)['wtxid'] for _ in range(3)]
  File "test/functional/test_framework/wallet.py", line 63, in send_self_transfer
    txid = from_node.sendrawtransaction(tx_hex)
  File "test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "test/functional/test_framework/authproxy.py", line 146, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: bad-txns-inputs-missingorspent (-25)

test: Fix intermittent issue in p2p_feefilter fa3af2c0d3
DrahtBot added the label Tests on Oct 17, 2020
in test/functional/p2p_feefilter.py:114 in fa3af2c0d3 outdated
```
 110 | @@ -111,6 +111,7 @@ def test_feefilter(self):
 111 |          txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00020000'), from_node=node0)['wtxid'] for _ in range(3)]
 112 |          conn.wait_for_invs_to_match(txids)
 113 |          conn.clear_invs()
 114 | +        self.sync_mempools()  # must be sure node 1 has received all txs
```
fjahr commented at 4:20 PM on October 18, 2020:

I am not sure if we still need the same on L102 then?

Also the comment above seems incorrect: There are three transactions being sent, not one.

MarcoFalke commented at 7:33 AM on October 19, 2020:

If miniwallet is spending the change output of the previous call (which has been sent on node0), the same tx needs to be sent to node1 for the change output to be spendable there as well.

Generally, we need this everywhere where from_node changes between invocations.

MarcoFalke commented at 7:44 AM on October 19, 2020:

Also the comment above seems incorrect: There are three transactions being sent, not one.

Thanks, fixed typo
fjahr commented at 4:22 PM on October 18, 2020: member

utACK fa3af2c0d3b3ed185fb8c6105dc2d26dc66632af

This certainly helps but I had some questions.
test: Fix typo (one tx is enough) in p2p_feefilter fa5a91a352
guggero commented at 8:37 AM on October 22, 2020: contributor

ACK fa5a91a3
MarcoFalke merged this on Oct 22, 2020
MarcoFalke closed this on Oct 22, 2020
sidhujag referenced this in commit c7fe952fc1 on Oct 22, 2020
MarcoFalke deleted the branch on Oct 28, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels