Stable/backport 0.7.2 release plan #2021

issue luke-jr opened this issue on November 16, 2012
  1. luke-jr commented at 6:53 PM on November 16, 2012: member

    Continuing from #2009...

    New fixes in master since previous list (@gavinandresen Are these OK to backport now as well?):

    • 90841fd (#1984) VariantClear@4 + shutdown@8 patch
    • 4ade04d (#2012) Print error for coinbase-pays-too-much case of ConnectBlock failing @Diapolo 6b3783a does change strings, but only the English in them, not the meaning, so the old translations are direct 1:1 mapping. @gavinandresen If the NACKs are debatable (if not, just say so), I'd like to clarify whether the memset one is a (minor) security fix or not?
  2. gavinandresen commented at 8:36 PM on November 16, 2012: contributor

    Those two are fine.

    memset change is too many lines of code changes for essentially zero net security benefit (if the attacker can read your bitcoin process' memory then you're already toast).

  3. luke-jr commented at 9:29 PM on November 16, 2012: member
  4. luke-jr commented at 9:37 PM on November 16, 2012: member

    #2022 looks like a good idea to throw into this too.

  5. Diapolo commented at 9:41 PM on November 16, 2012: none

    @luke-jr https://github.com/bitcoin/bitcoin/commit/6b3783a Is fine with me then, your explanation did it's job ;). Just wondering, if the legacy translations will still be used then? I have new translation files ready in another pull now btw.

  6. luke-jr commented at 10:08 PM on November 16, 2012: member

    @Diapolo Gavin NACK'd 6b3783a anyway, so it won't be in 0.7.2. Maybe 0.7.3 :) I've pulled in translations of strings that were missing for 0.7.1, if that's what you mean by the second part.

  7. luke-jr commented at 9:08 AM on November 17, 2012: member
  8. luke-jr commented at 2:40 PM on November 19, 2012: member

    Should we wait for #1927?

  9. Diapolo commented at 9:35 PM on November 19, 2012: none

    @luke-jr I would vote no, as this is just a small glitch but not really a heavy UX problem IMHO. I would much more love to see #2024 get in 0.7.2.

  10. laanwj commented at 6:52 AM on November 20, 2012: member

    Agreed with Diapolo. #2024 is a fix for a boost issue which makes boost::path unsafe to use in global constuctors on windows. This can cause a crash at shutdown. #1927 is 'nice to have' category but no need to wait for it.

  11. luke-jr commented at 8:12 PM on November 22, 2012: member

    Backported #2024, added release notes (+ bumped versions), and tagged v0.7.2rc1.

  12. sipa commented at 10:24 PM on November 22, 2012: member

    ACK on the diff between v0.7.1 and 0dba651def5 (v0.7.2rc1). I can't build myself right now, unfortunately.

    I didn't look at the changed translations closely.

  13. luke-jr commented at 12:58 AM on November 23, 2012: member
  14. luke-jr commented at 12:22 PM on November 30, 2012: member

    v0.7.2rc2 is tagged, if anyone else can contribute gitian builds...

  15. gavinandresen commented at 3:13 PM on November 30, 2012: contributor

    tagged at gitorious?

    It is confusing and error-prone to be using github for issues and major releases, but gitorious for a seemingly random collection of stuff.

  16. laanwj closed this on Oct 22, 2013

  17. HashUnlimited referenced this in commit 3d9e480e88 on Apr 6, 2018
  18. KolbyML referenced this in commit 3845c18723 on Dec 5, 2020
  19. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me