test: Suppress epoll_ctl data race #20218

1. 
   MarcoFalke commented at 12:21 pm on October 22, 2020: member

   Happens intermittently: https://cirrus-ci.com/task/5462892373868544?command=ci#L5385
2. DrahtBot added the label Tests on Oct 22, 2020
3. 
   hebasto commented at 5:01 pm on November 10, 2020: member

   I think our code should fixed to prevent data race in MaybeCompactWalletDB instead of silencing a warning as it seems related to CScheduler rather internal BDB code.

   Updated.

4. 
   MarcoFalke commented at 5:05 pm on November 10, 2020: member

   @hebasto I agree, but until someone figured out where the issue happens and how to fix it, we should suppress the intermittent failures, because they are hurting the project.
5. in test/sanitizer_suppressions/tsan:23 in fa5c8f4b70 outdated

   19@@ -20,6 +20,7 @@ race:fHaveGenesis
   20 race:ProcessNewBlock
   21 race:ThreadImport
   22 race:LoadWallet
   23+race:MaybeCompactWalletDB
   

   ---

   ---

   

   hebasto commented at 8:25 pm on November 10, 2020:

   0race:epoll_ctl
   

   as log contains

   0SUMMARY: ThreadSanitizer: data race (/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/bitcoind+0x8e332) in epoll_ctl
   

   ?

   ---

   

   MarcoFalke commented at 9:10 am on November 11, 2020:

   thanks, fixed
6. 
   hebasto commented at 8:32 pm on November 10, 2020: member

   Approach ACK fa5c8f4b7027200d8f54aad83ab5c1bfc5a42c90.

   It seems the data race in epoll_ctl could be false positive, and be caused by clang tsan instrumentation code (e.g., https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20131007/190642.html). But not for sure, of course.

   Also there is a possibility that this issue is/will be fixed in newer libevent versions.

7. MarcoFalke renamed this:
   test: Suppress MaybeCompactWalletDB data race
   test: Suppress epoll_ctl data race
   on Nov 11, 2020
8. test: Suppress epoll_ctl data race fa949b3c13
9. MarcoFalke force-pushed on Nov 11, 2020
10. hebasto approved
11. 
    hebasto commented at 9:21 am on November 11, 2020: member

    ACK fa949b3c1325693ea7ecc5556b2de50d2a6c9ead, I have reviewed the code and it looks OK, I agree it can be merged.
12. 
    DrahtBot commented at 1:47 pm on November 11, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15719 (Wallet passive startup by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. MarcoFalke merged this on Nov 11, 2020
14. MarcoFalke closed this on Nov 11, 2020

    ---

15. MarcoFalke deleted the branch on Nov 11, 2020
16. 
    MarcoFalke commented at 12:42 pm on December 3, 2020: member

    Not sure why, but this doesn’t work:

    https://cirrus-ci.com/task/5734386425397248?command=ci#L5451

17. 
    hebasto commented at 12:48 pm on December 3, 2020: member

    Not sure why, but this doesn’t work:

    https://cirrus-ci.com/task/5734386425397248?command=ci#L5451

    Indeed (

18. hebasto referenced this in commit d71e29e3e8 on Dec 22, 2020
19. 
    hebasto commented at 3:36 pm on December 22, 2020: member

    @MarcoFalke

    Not sure why, but this doesn’t work:

    https://cirrus-ci.com/task/5734386425397248?command=ci#L5451

    See #20745.

20. MarcoFalke referenced this in commit 9286b1cbce on Dec 22, 2020
21. mjdietzx referenced this in commit 5461c46e86 on Dec 26, 2020
22. Fabcien referenced this in commit b3c5178d5e on Dec 22, 2021
23. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke hebasto DrahtBot

Labels
Tests