RPC bumpfee error with explicit feerate #20219

issue jonatack opened this issue on October 22, 2020
  1. jonatack commented at 4:44 PM on October 22, 2020: member

    RPC bumpfee with an explicit feerate using conf_target and estimate_mode errors with JSONRPCException: JSON integer out of range (-1).

  2. jonatack added the label Bug on Oct 22, 2020
  3. jonatack commented at 5:56 PM on October 25, 2020: member

    Issue can be reproduced with the following code:

    diff --git a/test/functional/wallet_bumpfee.py b/test/functional/wallet_bumpfee.py
    +++ b/test/functional/wallet_bumpfee.py
    @@ -17,7 +17,7 @@ from decimal import Decimal
    -from test_framework.messages import BIP125_SEQUENCE_NUMBER, CTransaction
    +from test_framework.messages import BIP125_SEQUENCE_NUMBER, COIN, CTransaction
     from test_framework.test_framework import BitcoinTestFramework
    @@ -36,6 +36,8 @@ NORMAL       = 0.00100000
     TOO_HIGH     = 1.00000000
     
    +BTC_MODE = "BTC/kB"
    +SAT_MODE = "sat/B"
     
    @@ -77,8 +79,8 @@ class BumpFeeTest(BitcoinTestFramework):
             self.test_invalid_parameters(rbf_node, dest_address)
    -        test_simple_bumpfee_succeeds(self, "default", rbf_node, peer_node, dest_address)
    -        test_simple_bumpfee_succeeds(self, "fee_rate", rbf_node, peer_node, dest_address)
    +        for mode in ["default", "fee_rate", BTC_MODE, SAT_MODE]:
    +            test_simple_bumpfee_succeeds(self, mode, rbf_node, peer_node, dest_address)
             test_feerate_args(self, rbf_node, peer_node, dest_address)
    @@ -132,6 +134,13 @@ def test_simple_bumpfee_succeeds(self, mode, rbf_node, peer_node, dest_address):
         if mode == "fee_rate":
             bumped_psbt = rbf_node.psbtbumpfee(rbfid, {"fee_rate": NORMAL})
             bumped_tx = rbf_node.bumpfee(rbfid, {"fee_rate": NORMAL})
    +    elif mode == BTC_MODE:
    +        bumped_psbt = rbf_node.psbtbumpfee(rbfid, {"conf_target": NORMAL, "estimate_mode": BTC_MODE})
    +        bumped_tx = rbf_node.bumpfee(rbfid, {"conf_target": NORMAL, "estimate_mode": BTC_MODE})
    +    elif mode == SAT_MODE:
    +        sat_fee = NORMAL * COIN / 1000  # convert NORMAL from BTC/kB to sat/B
    +        bumped_psbt = rbf_node.psbtbumpfee(rbfid, {"conf_target": sat_fee, "estimate_mode": SAT_MODE})
    +        bumped_tx = rbf_node.bumpfee(rbfid, {"conf_target": sat_fee, "estimate_mode": SAT_MODE})
         else:
             bumped_psbt = rbf_node.psbtbumpfee(rbfid)
             bumped_tx = rbf_node.bumpfee(rbfid)
    
  4. meshcollider referenced this in commit 5d32009f1a on Nov 4, 2020
  5. jonatack commented at 8:39 AM on November 4, 2020: member

    Fixed by #20220.

  6. jonatack closed this on Nov 4, 2020

  7. MarcoFalke locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me