rpc, wallet: Expose wallet id in getwalletinfo RPC output #20243

1. 
   hebasto commented at 12:10 pm on October 26, 2020: member

   Based on #20205.
2. fanquake added the label Wallet on Oct 26, 2020
3. MarcoFalke added this to the milestone 22.0 on Oct 26, 2020
4. 
   jonatack commented at 12:27 pm on October 26, 2020: member

   Seems useful if an id is added, which is under debate. Can haz test?
5. 
   DrahtBot commented at 3:59 pm on October 26, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20773 (refactor: split CWallet::Create by S3RK)
   • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. hebasto closed this on Oct 26, 2020

   ---

7. hebasto reopened this on Oct 26, 2020

   ---

8. DrahtBot added the label Needs rebase on Nov 9, 2020
9. wallet: Properly support a wallet id

   Adds a unique id for each wallet that is saved in a new "walletid"
   record. For compatibility, wallets using BDB will use the BDB generated
   id. All other wallets will have a randomly generated id if an id does
   not already exist.

   30a02e9d60
10. rpc, wallet: Expose wallet id in getwalletinfo RPC output b7eb69c48d
11. hebasto force-pushed on Nov 9, 2020
12. 
    hebasto commented at 7:14 pm on November 9, 2020: member

    Rebased 17a20b94be63550fc021b7c6e0ed3d4dce834cdc -> b7eb69c48d1f0411abc16dc3210d86a3d4039fd7 (pr20243.01 -> pr20243.02).
13. DrahtBot removed the label Needs rebase on Nov 9, 2020
14. 
    luke-jr commented at 9:45 pm on December 5, 2020: member

    @jonatack BDB wallets already have an id
15. 
    jonatack commented at 3:19 pm on March 26, 2021: member

    Concept ACK, first skim of the code looks reasonable
16. 
    DrahtBot commented at 3:10 pm on May 19, 2021: member

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

17. DrahtBot added the label Needs rebase on May 19, 2021
18. 
    hebasto commented at 9:16 pm on May 22, 2021: member

    Waiting for a #20205, and closing for now.
19. hebasto closed this on May 22, 2021

    ---

20. DrahtBot locked this on Aug 18, 2022

Contributors
hebasto jonatack DrahtBot luke-jr

Labels
Wallet Needs rebase

Milestone
22.0