bitcoin-qt.exe crash with 0.7.1 (reproducible) #2025

Just add -proxy=crashme as parameter and on Windows and this will lead to an APPCRASH.

I looked what that parameter causes, which is calling InitError(), which aborts AppInit2() and causes a return 1; to exit the client.

Knowing this I was placing a return false; in AppInit2() to see when the crash starts to occur. This is the case after the first bitdb.open() in Step 5 of the initialisation (https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L587).

I digged deeper into this and found out, that the crash is triggered in CDBEnv::EnvShutdown() (https://github.com/bitcoin/bitcoin/blob/master/src/db.cpp#L41), which is called when destroying the bitdb global.

What I did not yet fully understand (because of a bad working Debugger), why would DbEnv(0).remove(GetDataDir().string().c_str() (https://github.com/bitcoin/bitcoin/blob/master/src/db.cpp#L41) cause this. Is it a problem with GetDataDir() or string()?

Anyway, I have a fix ready, which prevents this crash #2024.

Perhaps there is a better way to fix this, so core devs should take a look.

Cannot reproduce this problem on 0.7.1 nor master, either with or without your patch :-/

@laanwj Strange ... have you got a Windows machine, as it only happens on Windows. I know sipa could not reproduce it on Linux and it also does not happen with bitcoind.

hmm, I just get an error message that the proxy adress is invalid when I type: bitcoin-qt.exe -proxy=crashme in the windows 8 command prompt (cmd). Then bitcoin closes.

Also just getting an invalid proxy error on Win7.

I had a non default datadir set also, perhaps that fact leads to the crash. Closing this, as the patch is merged.

@Diapolo Care to verify 0.7.2rc1 fixes this? http://luke.dashjr.org/programs/bitcoin/files/bitcoin-qt/0.7.2/test/rc1/

@luke-jr Yeah, I'll take a look now, will report back in a few minutes.

Edit: Crash is gone, fix is working!